Event for dynamic fee update #920
Labels
Comments
|
I don't know what this is supposed to be, but it leads to a registration that is followed by pretty much nothing. Please stop spamming my report. |
floor-licker
added a commit
to floor-licker/v4-core
that referenced
this issue
Dec 12, 2024
In response to issue Uniswap#920. This event should then be emitted in every call to `updateDynamicLPFee` in contracts which inherit from `IPoolManager`
floor-licker
added a commit
to floor-licker/v4-core
that referenced
this issue
Dec 12, 2024
…r.sol In response to Issue Uniswap#920. The event is declared in `IPoolManager.sol` which `PoolManager.sol` inherits from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component
General design optimization (improving efficiency, cleanliness, or developer experience)
Describe the suggested feature and problem it solves.
While implementing support for UniswapV4 in my software, I noticed there is no event for dynamic fee updates. I realize that hooks can override fees anyways, which will already make fully supporting UniswapV4 rather complicated. It would be appreciated if at least dynamic fees can be handled through events.
Describe the desired implementation.
Emit event in updateDynamicLPFee().
Describe alternatives.
No response
Additional context.
No response
The text was updated successfully, but these errors were encountered: