Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License changes to encourage hook developments #351

Open
0xCheetah opened this issue Sep 13, 2024 · 1 comment
Open

License changes to encourage hook developments #351

0xCheetah opened this issue Sep 13, 2024 · 1 comment

Comments

@0xCheetah
Copy link

As it was discussed in the Uniswap HackerHouse event, it will be great if all multicall & permit scripts become MIT licensed. It will also encourage new directions for hook creations.

A. Multicall: One benefit is that the community will be enabled to build hooks that incorporate multicall in them with any license. This is particularly useful for hooks that interact directly with v4 core, as opposed to the periphery, as they may need to trigger a sequence of calls to the core. For example, an aggregator contract which is also a hook.

  • v4-periphery/src/base/Multicall_v4.sol (now GPL)
  • v4-periphery/src/interfaces/IMulticall_v4.sol (now UNLICENSED)

B. Permit2: Similar to the previous argument, Permit2Forwarder can be readily used by any contract that interacts directly with v4 core. Making Permit2Forwarder MIT encourages permit2 adoption.

  • v4-periphery/src/base/Permit2Forwarder.sol (now GPL)

C. ERC721Permit: Similar to the previous argument, it encourages new directions for hook creations, when hooks issue NFTs.

  • v4-periphery/src/base/ERC721Permit_v4.sol (now GPL)
  • v4-periphery/src/interfaces/IERC721Permit_v4.sol (now GPL)
  • v4-periphery/src/base/UnorderedNonce.sol (now GPL)
  • v4-periphery/src/libraries/ERC721PermitHash.sol (now GPL)

@hensha256 @snreynolds @saucepoint

Copy link

linear bot commented Sep 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant