Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Allow to select an open graph to explore paths #124

Open
martinec opened this issue Nov 4, 2018 · 2 comments
Open

[feature] Allow to select an open graph to explore paths #124

martinec opened this issue Nov 4, 2018 · 2 comments

Comments

@martinec
Copy link
Member

martinec commented Nov 4, 2018

Is your feature request related to a problem? Please describe.

PR #123 introduces a redesign of the explore graph paths frame

feature_redesign_explore

Describe the solution you'd like

It would be worth if the user can choose a graph among those already open.

Describe alternatives you've considered

The approach to track open graphs is already implemented on the Find and replace dialog thorough the use of an observer pattern.

@martinec martinec changed the title [enhance] Allow to select an open graph to Explore graph paths [enhance] Allow to select an open graph to explore paths Nov 4, 2018
@martinec martinec changed the title [enhance] Allow to select an open graph to explore paths [feature] Allow to select an open graph to explore paths Nov 4, 2018
@martinec martinec changed the title [feature] Allow to select an open graph to explore paths [feature #124] Allow to select an open graph to explore paths Nov 4, 2018
@martinec martinec changed the title [feature #124] Allow to select an open graph to explore paths [feature] Allow to select an open graph to explore paths Nov 4, 2018
@selgueti
Copy link
Contributor

To implement this feature, I need to modify three files.
Do I open three PRs (one per file) to apply Google’s Java styling and a fourth to apply changes, or one PR for styling all three files and a second for changes ?

@martinec
Copy link
Member Author

martinec commented May 14, 2022

You are not supposed to make changes to the code style of a whole file except when your changes modify it completely. That being said, yes, you must open two PRs : 1) refactor and 2) feature.

It is nice to know that you are working on this feature!

selgueti added a commit to selgueti/gramlab-ide that referenced this issue May 17, 2022
…paths

Activate Tools > Explore graph paths if at least one graph frame is open.
selgueti added a commit to selgueti/gramlab-ide that referenced this issue May 17, 2022
Change type of inputGraphName to JCheckBox
selgueti added a commit to selgueti/gramlab-ide that referenced this issue May 17, 2022
GraphPathFrame is now an observer of GraphFrame
selgueti added a commit to selgueti/gramlab-ide that referenced this issue May 17, 2022
selgueti added a commit to selgueti/gramlab-ide that referenced this issue May 17, 2022
@selgueti selgueti mentioned this issue May 17, 2022
33 tasks
selgueti added a commit to selgueti/gramlab-ide that referenced this issue May 25, 2022
…paths

Activate Tools > Explore graph paths if at least one graph frame is open.
selgueti added a commit to selgueti/gramlab-ide that referenced this issue May 25, 2022
Change type of inputGraphName to JCheckBox
selgueti added a commit to selgueti/gramlab-ide that referenced this issue May 25, 2022
GraphPathFrame is now an observer of GraphFrame
selgueti added a commit to selgueti/gramlab-ide that referenced this issue May 25, 2022
selgueti added a commit to selgueti/gramlab-ide that referenced this issue May 25, 2022
selgueti added a commit to selgueti/gramlab-ide that referenced this issue May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants