Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erronous undo behavior #143

Open
RaadDalaq opened this issue Apr 3, 2020 · 0 comments
Open

Erronous undo behavior #143

RaadDalaq opened this issue Apr 3, 2020 · 0 comments
Assignees
Milestone

Comments

@RaadDalaq
Copy link

Issue

  • undoing node serialized data breaks the graph currently, it seems like only changes to NodeGUI are recorded, for example, the filter node doesn't record changes to the filters list, only the changes to the output nodes, so if you change the filter regex on an entry, it will update the output connection label but when you undo it will only undo the label on the output connection but not the actual change (this is also true when adding new filters/removing them) it looks like RecordUndoScope isn't working as intended.
@hiroki-o hiroki-o self-assigned this Apr 5, 2020
@hiroki-o hiroki-o added this to the 1.7.0 milestone Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants