Oldest command to send is off by 1 with sparsetickbuffer

[AnthonyB28]

FPSSample/Assets/Scripts/Game/Main/ClientGameLoop.cs

Line 446 in 147f471

var oldestCommandToSend = Mathf.Max(prevTick, m_PredictedTime.tick - NetworkConfig.commandClientBufferSize);

This appears to be off by 1.
Suppose the predicted tick is 21444.
21444 - 32 (the constant buffer size) = 21412

This will try to store from 21412 up to and including 21444. Notice that after the loop ends, we store the predicted tick. So this method is storing 33 elements, not 32.

If you try to do a TryGetValue with tick 21412 it will return false being an "Invalid" tick to the buffer.