Skip to content

Commit e8abed8

Browse files
committed
shortened comments
1 parent 5eaea49 commit e8abed8

1 file changed

Lines changed: 2 additions & 14 deletions

File tree

Tools/CI/Settings/InputSystemSettings.cs

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,29 +21,17 @@ public class InputSystemSettings : AnnotatedSettingsBase
2121
public static readonly string BranchName = "develop";
2222
public static readonly string InputSystemPackageName = "com.unity.inputsystem";
2323

24-
// PMDT (Package Manager Doctools) 2.3 has been unmaintained for ~3 years and its bundled DocFX
25-
// started failing intermittently on CI (the "manual" folder silently not being generated) due to
26-
// unrelated tooling backports on the Yamato images. Per USF Docs Engineering guidance, the recommended fix is
27-
// to upgrade to a current PMDT release rather than continue pinning the old version.
28-
//
2924
// NOTE: Starting with PMDT 3.0.0, DocFX is no longer bundled with the package and must be
3025
// installed separately as a dotnet tool. See:
3126
// https://docs.unity3d.com/Packages/com.unity.package-manager-doctools@3.14/manual/installation.html
3227
//
3328
// dotnet SDK availability: confirmed present on package-ci images (Windows, Mac, and Ubuntu) via
3429
// #devs-pets / #devs-ci Slack history - it's a centrally maintained, version-pinned component of
35-
// the image family (e.g. package-ci/ubuntu-22.04:v4 SDK version pinning discussion, and a Windows
36-
// package-ci job observed spawning a .NET 8 subprocess), not something jobs install themselves.
37-
// So no extra .NET SDK install step is needed here.
30+
// the image family. So extra .NET SDK install step is needed here.
3831
//
3932
// NuGet source reachability - `dotnet tool install` needs to resolve the docfx package from a feed.
4033
// There's no nuget.config at the repo root (only Tools/CI/nuget.config, which NuGet won't discover
41-
// from here since it only walks upward from the working directory), so we pin --add-source
42-
// explicitly below to Unity's internal Artifactory NuGet proxy - the same source Tools/CI/nuget.config
43-
// uses, and one we know CI agents can already reach since the recipe-regeneration job restores
44-
// packages through it. Default sources (nuget.org) are likely unreachable from these locked-down
45-
// build agents. Still worth confirming on the first real CI run that Artifactory actually mirrors
46-
// the "docfx" package specifically (vs. only packages requested before).
34+
// from here since it only walks upward from the working directory).
4735
public static readonly string DocfxVersion = "2.70.0";
4836
public static readonly string NugetInternalSource = "https://artifactory.prd.it.unity3d.com/artifactory/api/nuget/v3/nuget";
4937

0 commit comments

Comments
 (0)