Add code review changes Hakan requested.

Author: Darren-Kelly-Unity

Assets/Tests/InputSystem/ActuationPressPointTests.cs

@@ -97,7 +97,7 @@ public void Actions_ButtonIsPressed_UsesPressInteractionWhenControlPressPointUns
 
     [Test]
     [Category("Actions")]
-    public void Actions_Vector2IsPressed_ControlPressPointOverridesPressInteraction()
+    public void Actions_Vector2IsPressed_PressInteractionOverridesControlPressPoint()
     {
         InputSystem.settings.defaultButtonPressPoint = 0.5f;
         InputSystem.settings.buttonReleaseThreshold = 0.8f;
@@ -111,11 +111,11 @@ public void Actions_Vector2IsPressed_ControlPressPointOverridesPressInteraction(
             type: InputActionType.Value,
             expectedControlType: "Vector2",
             binding: "<Gamepad>/leftStick",
-            interactions: "press(pressPoint=0.6)");
-        gamepad.leftStick.pressPoint = 0.85f;
+            interactions: "press(pressPoint=0.85)");
+        gamepad.leftStick.pressPoint = 0.6f;
         action.Enable();
 
-        // Above interaction threshold (0.6) but below control threshold (0.85).
+        // Above control threshold (0.6) but below interaction threshold (0.85).
         Set(gamepad.leftStick, new Vector2(0.7f, 0f));
         InputSystem.Update();
         Assert.That(action.IsPressed(), Is.False);

Packages/com.unity.inputsystem/InputSystem/Controls/IActuationPressPoint.cs

@@ -13,11 +13,6 @@ namespace UnityEngine.InputSystem.Controls
     /// <seealso cref="Vector2Control"/>
     internal interface IActuationPressPoint
     {
-        /// <summary>
-        /// Layout-configured press threshold, or a value less than or equal to zero when unset.
-        /// </summary>
-        float pressPoint { get; }
-
         /// <summary>
         /// Effective press threshold: <see cref="pressPoint"/> when set, otherwise the global default.
         /// </summary>

Packages/com.unity.inputsystem/InputSystem/Runtime/Actions/InputActionState.cs

@@ -1627,10 +1627,9 @@ internal float GetActuationPressThreshold(InputControl control, BindingState* bi
 
             if (control is IActuationPressPoint actuation)
             {
-                if (actuation.pressPoint > 0)
-                    return actuation.pressPointOrDefault;
                 if (hasExplicitPressThreshold)
                     return explicitPressThreshold;
+
                 return actuation.pressPointOrDefault;
             }
 

Packages/com.unity.inputsystem/InputSystem/Runtime/Controls/ButtonControl.cs

@@ -61,7 +61,6 @@ public class ButtonControl : AxisControl, IActuationPressPoint
         /// </example>
         /// </remarks>
         public float pressPoint = -1;
-        float IActuationPressPoint.pressPoint => pressPoint;
 
         /// <summary>
         /// Return <see cref="pressPoint"/> if set, otherwise return <see cref="InputSettings.defaultButtonPressPoint"/>.

Packages/com.unity.inputsystem/InputSystem/Runtime/Controls/Vector2Control.cs

@@ -51,8 +51,6 @@ public class Vector2Control : InputControl<Vector2>, IActuationPressPoint
         /// <seealso cref="UnityEngine.InputSystem.InputSettings.defaultButtonPressPoint"/>
         public float pressPoint = -1.0f;
 
-        float IActuationPressPoint.pressPoint => pressPoint;
-
         /// <summary>
         /// Return <see cref="pressPoint"/> if set, otherwise return <see cref="UnityEngine.InputSystem.InputSettings.defaultButtonPressPoint"/>.
         /// </summary>