Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weights and Biases instead of Tensorboard (PR request) #5733

Closed
alexge233 opened this issue Apr 20, 2022 · 3 comments
Closed

Weights and Biases instead of Tensorboard (PR request) #5733

alexge233 opened this issue Apr 20, 2022 · 3 comments
Assignees
Labels
request Issue contains a feature request.

Comments

@alexge233
Copy link

Is your feature request related to a problem? Please describe.
I'm working as part of a team that runs multiple ml-agents on our own PCs and also plan on placing them on VPS. We want to collate and compare results using wandb instead of tensorboard as this will allow us to work better as a team.

Describe the solution you'd like
I've implemented a WandbWriter in my local git clone under ml-agents/mlagents/trainers/stats.py. I've added a simple unit test in ml-agents/mlagents/trainers/tests/test_stats.py, and injected the writer in ml-agents/mlagents/plugins/stats_writer.py so it becomes available. I haven't actually tested it with the samples/examples, only locally.

Describe alternatives you've considered
I can imagine the alternative to be to package my version of mlagents and distribute it to my colleagues, but that's less than ideal. It also means I'll have to copy, merge and maintain an updated copy. I'd rather not do that.

Additional context
This repo seems to have reached its maximum forks, and therefore I could not Fork + PR. Hence opening this issue. Happy to have the changes reviews, rejected, commented on, etc. but I can't seem to do that as things stand.
Also, I may need some guidance on how exactly you expect the format for the kwargs being passed to the writer to look like.

@alexge233 alexge233 added the request Issue contains a feature request. label Apr 20, 2022
@andrewcoh
Copy link
Contributor

andrewcoh commented May 4, 2022

Hi @alexge233

This does sound interesting and we would like to see the PR. I am not totally sure what you mean by

This repo seems to have reached its maximum forks

Is it possible that is on your end i.e. your person github has reached maximum forks? If I'm not mistaken, it looks like you've successfully forked ML-Agents here.

@alexge233
Copy link
Author

alexge233 commented May 5, 2022

This is interesting; when I tried to fork it through github it gave me an error of max forks allowed for this repository! Ok, this is just preliminary, I've had a look at the code and made some changes. PR has been submitted let me know anything you don't like, including suggestions, coding style, documentation, etc.

@andrewcoh
Copy link
Contributor

Thanks, I'll check it out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Issue contains a feature request.
Projects
None yet
Development

No branches or pull requests

3 participants