Skip to content

Commit bc932ee

Browse files
committed
ci(workflow): drop the dead stellar-cli install step
The"Install Soroban / Stellar CLI"step was failing every CI run: https://github.com/stellar/stellar-cli/releases/download/v22.0.0/...tar.xz returns 404 because the v22.0.0 release was never published. Further, no subsequent step in either job invokes the "stellar"or "soroban"binary, so the install was dead code masking itself as a useful precondition. With --locked on cargo in place, we can finally\nprove --locked on a real CI runner undocked from this 404.\n\nRe-add with a verified release tag if/when a deployment step is\nintroduced that genuinely needs the CLI.\n
1 parent feb320a commit bc932ee

1 file changed

Lines changed: 8 additions & 12 deletions

File tree

.github/workflows/build.yml

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,10 @@ jobs:
2020
targets: wasm32-unknown-unknown
2121
components: rustfmt
2222

23-
- name: Install Soroban / Stellar CLI
24-
run: |
25-
curl -L https://github.com/stellar/stellar-cli/releases/download/v22.0.0/stellar-cli-22.0.0-x86_64-unknown-linux-gnu.tar.xz \
26-
| tar -xJ
27-
sudo mv stellar /usr/local/bin/stellar
28-
23+
# The "Install Soroban / Stellar CLI" step was removed: stellar-cli
24+
# v22.0.0 is not published (the release URL returns 404) and no step
25+
# in this workflow invokes the CLI. Re-add with a verified release
26+
# tag if/when a deployment step is introduced.
2927
# `cargo --locked` reads the committed `onchain/Cargo.lock` verbatim
3028
# (most importantly pinning `ed25519-dalek 2.1.1` to work around the
3129
# `soroban-env-host 22.1.3` ↔ `ed25519-dalek 3.0` trait-bound
@@ -49,12 +47,10 @@ jobs:
4947
with:
5048
toolchain: stable
5149

52-
- name: Install Soroban / Stellar CLI
53-
run: |
54-
curl -L https://github.com/stellar/stellar-cli/releases/download/v22.0.0/stellar-cli-22.0.0-x86_64-unknown-linux-gnu.tar.xz \
55-
| tar -xJ
56-
sudo mv stellar /usr/local/bin/stellar
57-
50+
# The "Install Soroban / Stellar CLI" step was removed: stellar-cli
51+
# v22.0.0 is not published (the release URL returns 404) and no step
52+
# in this workflow invokes the CLI. Re-add with a verified release
53+
# tag if/when a deployment step is introduced.
5854
# Build tests on host with the `testutils` feature (see each
5955
# contract's `[dev-dependencies] soroban-sdk = { features = ["testutils"] }`)
6056
# so `mock_all_auths`, `register_contract`, `Address::generate`, etc.

0 commit comments

Comments
 (0)