Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how we do YouTube embeds #213

Open
markspolakovs opened this issue Dec 15, 2019 · 4 comments
Open

Rework how we do YouTube embeds #213

markspolakovs opened this issue Dec 15, 2019 · 4 comments

Comments

@markspolakovs
Copy link
Member

Right now, while we can embed YouTube videos / streams on the website, it is a bit hacky and shit. We should consider a better solution, both visually and in terms of code style.

@markspolakovs
Copy link
Member Author

@Brookke I heard you had an idea about the design?

@Brookke
Copy link
Member

Brookke commented Dec 15, 2019

I think the simplest thing and first thing I would do would be to move the video below the current and next, in the same way banners appear - for consistency. If a banner is currently visible then it should replace the banner to avoid cluttering up the home page.

@Brookke
Copy link
Member

Brookke commented Dec 15, 2019

I also wonder if people would prefer to watch on the homepage of the site or have a banner equivalent that links to YouTube, similar to what we have with our URY session videos on the front page? That was traditionally what happened, but it was a more manual process, I like the idea of this being more automatic based on whether there’s a Video stream or not?

@markspolakovs
Copy link
Member Author

Good stuff. I think it's better to embed it if it's a live stream - it's far more eye-catching than "click here", which people may often ignore. The current implementation only embeds the stream if its associated show is live now, which we'd probably want to keep. VODs might be a different matter (in particular I'd rather not have them autoplay, which the current bodgy solution does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants