chore(1-3849): make IDs non-optional on front-end constraints. #10370
+226
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it so that we require constraints with IDs in more places (to avoid accidentally mixing up constraint states).
The next move is to make id required on IConstraint.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Enforce setting [constraintId] on incoming constraints
thomasheartman
force-pushed
the
push-rmuptsxsxsln
branch
4 times, most recently
from
1cd57ae to
7f8c840
Compare
thomasheartman
force-pushed
the
push-rmuptsxsxsln
branch
from
7f8c840 to
872c582
Compare
thomasheartman
force-pushed
the
push-rmuptsxsxsln
branch
3 times, most recently
from
06357c4 to
d5bb271
Compare
which is in the project overview.
thomasheartman
force-pushed
the
push-rmuptsxsxsln
branch
from
d5bb271 to
2916ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not touching playground
Also need to update segments
Before merging: add a flag
Just in case this causes significantly more processing work on the client, let's add a flag so that we can turn it off if we hear anything. I don't expect it to cause many issues, however, because (I think) we only fetch strategies for a flag on certain pages: