From e1188d14e610818509f9a12ec93ef7d6acc6fff6 Mon Sep 17 00:00:00 2001 From: Kamala Rocci Date: Fri, 9 Jan 2026 11:37:02 +0100 Subject: [PATCH 1/3] chore: update AddFilterButton text --- .../feature/FeatureToggleList/FeatureToggleListTable.test.tsx | 4 ++-- frontend/src/component/filter/AddFilterButton.tsx | 2 +- frontend/src/component/filter/Filters/Filters.test.tsx | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.test.tsx b/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.test.tsx index 10a724c5b4b3..77b05ea66449 100644 --- a/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.test.tsx +++ b/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.test.tsx @@ -96,7 +96,7 @@ test('Filter table by project', async () => { await screen.findByPlaceholderText(/Search/); await screen.getByRole('button', { - name: 'Filter', + name: 'Add Filter', }); await Promise.all( @@ -109,7 +109,7 @@ test('Filter table by project', async () => { setupNoFeaturesReturned(); - const addFilterButton = screen.getByText('Filter'); + const addFilterButton = screen.getByText('Add Filter'); addFilterButton.click(); const projectItem = await screen.findByRole('menuitem', { diff --git a/frontend/src/component/filter/AddFilterButton.tsx b/frontend/src/component/filter/AddFilterButton.tsx index b58cb98214ed..20d1f45bf481 100644 --- a/frontend/src/component/filter/AddFilterButton.tsx +++ b/frontend/src/component/filter/AddFilterButton.tsx @@ -57,7 +57,7 @@ export const AddFilterButton = ({ return (
}> - Filter + Add Filter { ); // initial selection list - const addFilterButton = await screen.findByText('Filter'); + const addFilterButton = await screen.findByText('Add Filter'); fireEvent.click(addFilterButton); expect((await screen.findByTestId(FILTERS_MENU)).textContent).toBe( 'StateTags', From b850f111ef12a492f69bf031e3366837304483ac Mon Sep 17 00:00:00 2001 From: Kamala Rocci Date: Fri, 9 Jan 2026 11:39:50 +0100 Subject: [PATCH 2/3] make filter lowercase --- .../feature/FeatureToggleList/FeatureToggleListTable.test.tsx | 4 ++-- frontend/src/component/filter/AddFilterButton.tsx | 2 +- frontend/src/component/filter/Filters/Filters.test.tsx | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.test.tsx b/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.test.tsx index 77b05ea66449..488a01dc7c1e 100644 --- a/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.test.tsx +++ b/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.test.tsx @@ -96,7 +96,7 @@ test('Filter table by project', async () => { await screen.findByPlaceholderText(/Search/); await screen.getByRole('button', { - name: 'Add Filter', + name: 'Add filter', }); await Promise.all( @@ -109,7 +109,7 @@ test('Filter table by project', async () => { setupNoFeaturesReturned(); - const addFilterButton = screen.getByText('Add Filter'); + const addFilterButton = screen.getByText('Add filter'); addFilterButton.click(); const projectItem = await screen.findByRole('menuitem', { diff --git a/frontend/src/component/filter/AddFilterButton.tsx b/frontend/src/component/filter/AddFilterButton.tsx index 20d1f45bf481..b779ebc7b2a0 100644 --- a/frontend/src/component/filter/AddFilterButton.tsx +++ b/frontend/src/component/filter/AddFilterButton.tsx @@ -57,7 +57,7 @@ export const AddFilterButton = ({ return (
}> - Add Filter + Add filter { ); // initial selection list - const addFilterButton = await screen.findByText('Add Filter'); + const addFilterButton = await screen.findByText('Add filter'); fireEvent.click(addFilterButton); expect((await screen.findByTestId(FILTERS_MENU)).textContent).toBe( 'StateTags', From 1dae51c8998e067de01a57b0ff191aac3ad9362f Mon Sep 17 00:00:00 2001 From: Kamala Rocci Date: Fri, 9 Jan 2026 11:58:28 +0100 Subject: [PATCH 3/3] update missing test --- .../ProjectFeatureToggles.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.test.tsx b/frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.test.tsx index caaaee108ef8..f62a7309b095 100644 --- a/frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.test.tsx +++ b/frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.test.tsx @@ -174,7 +174,7 @@ test('filters by flag author', async () => { route: '/projects/default', }, ); - const addFilter = await screen.findByText('Filter'); + const addFilter = await screen.findByText('Add filter'); fireEvent.click(addFilter); const createdBy = await screen.findByText('Created by');