Read session action as EDN map #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular this means that actions need not be present on blob generation. For a static client this is not really relevant. However a client which wants to provide extension points for dynamically added actions has to run make-blob every time an extension is added or removed. This is non-trivial business. With this change the blob update is not necessary anymore. Read: one compile step removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular this means that actions need not be present on blob
generation. For a static client this is not really relevant. However
a client which wants to provide extension points for dynamically
added actions has to run make-blob every time an extension is added
or removed. This is non-trivial business. With this change the blob
update is not necessary anymore.
Read: one compile step removed.