Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ App Calculs ] Angle mal positionné (résultats complémentaires) #248

Open
fmOOmf opened this issue Jun 3, 2022 · 2 comments · May be fixed by #254
Open

[ App Calculs ] Angle mal positionné (résultats complémentaires) #248

fmOOmf opened this issue Jun 3, 2022 · 2 comments · May be fixed by #254
Labels
bug Something isn't working

Comments

@fmOOmf
Copy link

fmOOmf commented Jun 3, 2022 •
edited
Loading

Bonjour à toute l'équipe
Avec les angles en degrés : taper cos(280).
Dans les résultats complémentaires, l'angle est positionné sur 80° au lieu de 280°.

Copie d'écran sur le simulateur :
image
image

When angles are in degree, in complimentary results accessible after computing cos(280), 280° is located at 80°.
Screenshots hereabove.
@Lauryy06 Lauryy06 added the bug Something isn't working label Jun 9, 2022
@lolocomotive
Copy link
Member

This happens for any angle between 270 and 360° (270 and 360 not included)

@lolocomotive
Copy link
Member

Seems to work when the result is exact (for example $cos(300°)=0.5$ , $cos(330°) = \frac{\sqrt{3}}{2})$
Maybe due to apps/calculation/additional_outputs/trigonometry_list_controller.cpp:66

  float angle = Shared::PoincareHelpers::ApproximateToScalar<float>(m_calculationStore.calculationAtIndex(0)->approximateOutput(context, Calculation::NumberOfSignificantDigits::Maximal), context);

@RedGl0w RedGl0w linked a pull request Jun 17, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes to the trigonometry additional result RedGl0w/epsilon
3 participants
@lolocomotive @Lauryy06 @fmOOmf