Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra fields to Profile #59

Closed
MarkvdKort opened this issue Nov 27, 2024 · 3 comments
Closed

Add extra fields to Profile #59

MarkvdKort opened this issue Nov 27, 2024 · 3 comments

Comments

@MarkvdKort
Copy link

  • Leeftijd
  • Geslacht
  • Postcode
  • Rol
@BasMichielsen
Copy link
Member

Hi Mark, I reckon this is on the profile endpoints, not on user. Also your fields are ambiguous:
Leeftijd should probably be DateOfBirth, as Age changes every year, but DateOfBirth does not.
Geslacht is a difficult field, do you mean Gender or Sex? What does the product owner expect here as possible inputs?
Postcode is fine
Rol What does this mean, should it be a free format text field?

@MarkvdKort
Copy link
Author

MarkvdKort commented Nov 27, 2024

Hi Bas, the list I named here is simply the list I received from the product owners. I did not think this out into detail since I am not responsible for building the backend. But like you said yes using date of birth would be better than just using age.

Role should probably become a free format text field since this will mostly be about the job of the user which can not be chosen easily from a preset list of values.

For Gender I would assume that Man, Women, Other or "I prefer not to say" should be sufficient but we will check that with the product owners. For now it would be nice if you could create an endpoint in which we can retrieve the different available genders so that this can always be easily modified when we get a reaction from the product owners.

@BasMichielsen
Copy link
Member

Let's just ask the product owner for a list. It makes little sense that you and I devise something.

@BasMichielsen BasMichielsen changed the title Add extra fields to user update endpoint Add extra fields to Profile Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants