Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Query without has more requery #32

Open
Uysim opened this issue Feb 5, 2022 · 3 comments
Open

Optimize Query without has more requery #32

Uysim opened this issue Feb 5, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Uysim
Copy link
Owner

Uysim commented Feb 5, 2022

@yunanhelmy had optimize this with PR #19. But from result issue #28 which lead us to revert back to ActiveRecord::Relation. Even so, I still think some developer need to optimize this query.
I think we should have two extra modules pagy_cursor/pagy/extras/optimal_cursor and pagy_cursor/pagy/extras/optimal_uuid_cursor which behave the same as #19 and return Ruby Array.
From that implementation developer able to pick the implementation that he want.

@Uysim Uysim added the enhancement New feature or request label Feb 5, 2022
@Uysim
Copy link
Owner Author

Uysim commented Feb 9, 2022

@yunanhelmy can you help in this contribution?

@yunanhelmy
Copy link
Contributor

@yunanhelmy can you help in this contribution?

@Uysim I'll help this one.

@yunanhelmy
Copy link
Contributor

@Uysim what about adding vars[:lazy] using default = true. Developer can pass { lazy: false } if they want to return an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants