Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add option to mute the error and/or disable lint checking #192

Open
nselvara opened this issue Aug 22, 2023 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@nselvara
Copy link

I'd appreciate a feature that allows to mute a warning/error and/or disable lint checking/code analysis for particular lines. Maybe to mute particular lines, we could add for example some kind of comments in the code.

-- lint_off
variable some_var: integer;
-- lint_on
@Schottkyc137
Copy link
Contributor

At the moment I don't think that this will be implemented. vhdl_ls is not a linter. If something is flagged as wrong, this means that it doesn't comply with the standard. Do you have a concrete use-case in mind?

@nselvara
Copy link
Author

Sorry, I didn't mean in particular the linter but the static code analysis. As an example this one could serve: #184
Or this one: #191

@Schottkyc137
Copy link
Contributor

Ah, I see. Yes, this would make more sense. However, I think that implementing this feature ist as hard or even harder than fixing the mentioned feature as there is currently no comprehensive way to get the tokens (and by that token [pun intended] no comprehensive way to get comments and/or tool directives for a certain line). An easier approach could be to turn on/off analysis for a file or a for a project completely. Would that be a solution?

@nselvara
Copy link
Author

I see, yeah I mean for the mean time that would be a sufficient solution. It's more like for developers who work on those projects could be a hint that the line is actually correct but the plugin flags it as an error. I'm not sure if that's maybe easier but what instead writing a comment but rather selecting lines of code and exculding those from the analysis. I think if the file/project can be excluded there must be some kind of flags that are stored so I assume that some lines of numbers can be somehow also included? I don't know hard this solution might be to implement.

@darsor
Copy link

darsor commented Oct 19, 2023

This feature would be very useful for PSL code, which is not currently supported by VHDL-LS.

@Schottkyc137 Schottkyc137 added the enhancement New feature or request label Mar 2, 2024
@Schottkyc137 Schottkyc137 self-assigned this Mar 6, 2024
@Schottkyc137 Schottkyc137 removed their assignment Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants