Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary Reduction in source repo #27

Open
SpookySkeletons opened this issue Mar 18, 2023 · 2 comments
Open

Binary Reduction in source repo #27

SpookySkeletons opened this issue Mar 18, 2023 · 2 comments

Comments

@SpookySkeletons
Copy link

Extremely cool project but noticed a few bits of concern in the git repo worth addressing.

There's a number of prebuilt blobs in the git project and a large amount of content that could be better served as git submodules with their own sub builds wired into the main build script.
Could lead to much improved ability to modify the program to suit individual needs, future contributions, and of course support for building and running on more platforms than win32.

Is cleaning up the source repo on the roadmap?

@VRCWizard
Copy link
Owner

I'm pretty new to this stuff so if you could recommend helpful links / information to look at in regards to this that would be great. I tend to code and implement cool ideas first and refactor later although this is a terrible way to do things.

@SpookySkeletons
Copy link
Author

SpookySkeletons commented Mar 19, 2023

If it gets the work done it's not terrible, just have to put in the effort to clean after! It's understandable.

For one as part of your process see if you can identify all the dependencies of your project and perhaps pull them in as separate git 'submodules' in an 'external' folder if you will.

This way you can track the actual commits of each individual dependency and easily identify upstream regressions and issues. Makes it very easy to secure, maintain, and update the project down the line.

Second is I would begin to automated the process of building each of these submodules you pull in and one by one turning them on so that your main build script builds them within their respective folders and then imports the binaries into the main project build as it progresses.

In this manner it can vastly improve the backend and longevity of the project.

EDIT: Do consider a linux/mac/multiplatform based build operation alongside, revamping your build process and adding multiplatform at the same time, overlay together pretty well assuming your dependencies don't hard require any win32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants