Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<C-w> + v and <C-w> + s split pane not working on VSCode 1.90 #9061

Closed
ljones140 opened this issue Jun 6, 2024 · 26 comments · Fixed by #9072
Closed

<C-w> + v and <C-w> + s split pane not working on VSCode 1.90 #9061

ljones140 opened this issue Jun 6, 2024 · 26 comments · Fixed by #9072

Comments

@ljones140
Copy link

ljones140 commented Jun 6, 2024

Describe the bug

Using <C-w> + v an + s` for new panes are no longer working when on latest version of VSCode 1.90
https://code.visualstudio.com/updates/v1_90

To Reproduce
Steps to reproduce the behavior:

  1. Ensure VSCode is version 1.90
  2. on a file press <C-w> followed by v or <C-w> followed by s

Expected behavior
New pane opens

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.27.3
  • VSCode version: 1.90
  • OS: Mac 14.5
@ljones140
Copy link
Author

Downgrading to VSCode 1.89.1 and split panes works

@levidavidmurray
Copy link

I didn't realize my VSCode updated and thought I was going crazy when <C-w> + v wasn't working. Hopefully we can get a quick resolution for this

@levidavidmurray
Copy link

Seems like this is due to some changes made for the new "Tab Multi Select" feature

I noticed that resourceOrContext and commandContext were undefined when the action was run via Command Palette > Split Editor. When run via VSCodeVim, they were both empty objects.

split-editor

Setting workbench.action.splitEditor and workbench.action.splitEditorOrthogonal action arguments to undefined seems to fix the immediate issue. But, I don't know enough about the architecture of VSCodeVim nor VSCode to say if this is the correct solution.

Recording.2024-06-06.192042.mp4

@sasacocic
Copy link

I'm having similar issues

<C-w> + v- vertical split

and

<C-w> + s - horizontal split

Are no longer working for me after updating to 1.90.0 of visual studio code

@david-xorcon
Copy link

Same here - broken since 1.90.0

@Yin-SHT
Copy link

Yin-SHT commented Jun 7, 2024

Same here

@ljones140 ljones140 changed the title <C-w> + n New vertical pane not working on VSCode 1.90 <C-w> + v New vertical pane not working on VSCode 1.90 Jun 7, 2024
@ljones140
Copy link
Author

I'm having similar issues

<C-w> + v- vertical split

and

<C-w> + s - horizontal split

Are no longer working for me after updating to 1.90.0 of visual studio code

I'll edit the issue to add these thanks

@ljones140 ljones140 changed the title <C-w> + v New vertical pane not working on VSCode 1.90 <C-w> + v and <C-w> + s pane not working on VSCode 1.90 Jun 7, 2024
@ljones140 ljones140 changed the title <C-w> + v and <C-w> + s pane not working on VSCode 1.90 <C-w> + v and <C-w> + s split pane not working on VSCode 1.90 Jun 7, 2024
@kianryan
Copy link

kianryan commented Jun 7, 2024

This wasn't broken on insiders until the latest update.
Now broken on 1.91.0-insider - same behaviour

@viddo
Copy link

viddo commented Jun 7, 2024

At least for vertical/horizontal splits one can one can add the following shortcuts to keybinding.json as a temporary workaround, I guess:

    {
        "key": "ctrl+w v",
        "command": "workbench.action.splitEditor"
    },
    {
        "key": "ctrl+w s",
        "command": "workbench.action.splitEditorDown"
    },

@dim-an
Copy link

dim-an commented Jun 7, 2024

Another possible workaround is to modify vim extension settings:

{
    ...
    "vim.normalModeKeyBindings": [
        {
            "before": ["C-w", "v"],
            "after": [":", "v", "s", "<Enter>"],
        },
        {
            "before": ["C-w", "s"],
            "after": [":", "s", "p", "<Enter>"],
        },
    ...
}

I like it better than modifying keybinding.json because it doesn't break Ctrl+W behaviour in insert mode.

@basictheprogram
Copy link

Adding same behavior for menu options

  • View > Editor Layout > Split Down
  • View > Editor Layout > Split Up

@jayhanjaelee
Copy link

Same Here

@viddo
Copy link

viddo commented Jun 10, 2024

Another possible workaround is to modify vim extension settings:

{
    ...
    "vim.normalModeKeyBindings": [
        {
            "before": ["C-w", "v"],
            "after": [":", "v", "s", "<Enter>"],
        },
        {
            "before": ["C-w", "s"],
            "after": [":", "s", "p", "<Enter>"],
        },
    ...
}

I like it better than modifying keybinding.json because it doesn't break Ctrl+W behaviour in insert mode.

This workaround works in stable / 1.19.0 but not in insiders version 1.91.0-insider, so there's probably more changes ahead that will break it again.

@aurum77
Copy link

aurum77 commented Jun 10, 2024

At least for vertical/horizontal splits one can one can add the following shortcuts to keybinding.json as a temporary workaround, I guess:

    {
        "key": "ctrl+w v",
        "command": "workbench.action.splitEditor"
    },
    {
        "key": "ctrl+w s",
        "command": "workbench.action.splitEditorDown"
    },

here's that but for config json

"vim.normalModeKeyBindings": [
    {
      "before": [
        "<C-w>",
        "v"
      ],
      "commands": [
        "workbench.action.splitEditor"
      ]
    },
    {
      "before": [
        "<C-w>",
        "s"
      ],
      "commands": [
        "workbench.action.splitEditorDown"
      ]
    },
]

@guunergooner
Copy link

At least for vertical/horizontal splits one can one can add the following shortcuts to keybinding.json as a temporary workaround, I guess:

    {
        "key": "ctrl+w v",
        "command": "workbench.action.splitEditor"
    },
    {
        "key": "ctrl+w s",
        "command": "workbench.action.splitEditorDown"
    },

here's that but for config json

"vim.normalModeKeyBindings": [
    {
      "before": [
        "<C-w>",
        "v"
      ],
      "commands": [
        "workbench.action.splitEditor"
      ]
    },
    {
      "before": [
        "<C-w>",
        "s"
      ],
      "commands": [
        "workbench.action.splitEditorDown"
      ]
    },
]

👍 Cool, add this configuration code snippet to setting.json to bypass the above issue.

@cochranjdlz
Copy link

For anyone interested, I was able to additionally add the following config to allow me to regain my keyboard navigation, which also broke when I updated.

  {
    "key": "ctrl+w k",
    "command": "workbench.action.navigateUp"
  },
  {
    "key": "ctrl+w j",
    "command": "workbench.action.navigateDown"
  },
  {
    "key": "ctrl+w h",
    "command": "workbench.action.navigateLeft"
  },
  {
    "key": "ctrl+w l",
    "command": "workbench.action.navigateRight"
  },

In my case, I'm used to using <C-k>, <C-l>, <C-j>, <C-h.

@junhan-z
Copy link

Same here.

Also I think ctrl+w o (show current panel and close others) and ctrl+w q (close current panel) are also broken.

@fivetran-danandreiganea

Same here

@CWEzio
Copy link

CWEzio commented Jun 20, 2024

Same problem

@jakyns
Copy link

jakyns commented Jun 20, 2024

when will this fix?

@jirol9xa
Copy link

same

@laipz8200
Copy link

Same here

@basictheprogram
Copy link

Still have the problem in 1.90.2 on macOS

@KuanYuLai
Copy link

same

@jakyns
Copy link

jakyns commented Jun 29, 2024

how can we push this to fix as soon as possible?

@cloone8
Copy link

cloone8 commented Jun 29, 2024

Same problem here! Would be great to have this fixed instead of having to use a workaround. Wish I could do this myself, but I haven't got the time to dive into a new open source project atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.