Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings vs bindingOverrides and keys vs key #78

Open
TwoClocks opened this issue Apr 6, 2023 · 3 comments
Open

bindings vs bindingOverrides and keys vs key #78

TwoClocks opened this issue Apr 6, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@TwoClocks
Copy link

As I've been adding more overrides, at some point I've made enough changes that I just want to skip the defaults. I'd assumed I just needed to change bindingOverrides to bindings and it would work. It doesn't.
I needed to go and change all the group bindings from keys to key.

It would be nice to just be able to flip back and forth at will.

Maybe this is a feature request, and not a bug.

@TwoClocks TwoClocks added the bug Something isn't working label Apr 6, 2023
@stevenguh stevenguh added enhancement New feature or request and removed bug Something isn't working labels Apr 8, 2023
@stevenguh
Copy link
Member

bindings is used to define the whole menu and bindingOverrides is designed to surgically update a few bindings (that's why it has keys). I agree that it could be better/seamless. Any idea?

@TwoClocks
Copy link
Author

So, my two cents:
Change all the docs to change any reference to 'keys' to 'key'
Change the code that parses the BindingOverrides to look for either 'key' or 'keys' (stay backwards compatible)

Having never looked at the code, maybe now you can use the same parsing code for both?

@stevenguh
Copy link
Member

Thanks for the suggestions. There some nuances for the overrides. In hinge sight, it is poorly defined API. Supporting both key and keys may help in this case. I feel like the whole overrides may need to overhaul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants