Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyline with "bulge" #23

Closed
Vadoola opened this issue Oct 22, 2024 · 1 comment
Closed

Polyline with "bulge" #23

Vadoola opened this issue Oct 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Vadoola
Copy link
Owner

Vadoola commented Oct 22, 2024

Earlier while doing some testing on the test files in the libredwg github repo, there was a file with a polyline that had 2 points, but a bulge defined, and it was closed, which made it look like a circle. (although in QCade deleting the buldge made it looks like a semi-circle).

I need to look into how this bulge works, and how to properly convert that to a polyline. Right now my logic looks at it and says it's a 2 point polyline, convert it to a normal line, and it straight and flat, but that's wrong. It looks like the original logic from Antonioaja didn't handle this either, I checked using version 0.3.0, and it ends up a polygon with 2 points, but still a straight line.

I guess the tricky part is going to be how do I represent this? Polygon's in QElectrotech can't be curved...I would need to try and segments it into multiple small lines, or try and represent it with arcs...which mathematically could get tricky, and you might end up with multiple arcs to create a shape that was a single polyline.

Donut.zip

@Vadoola Vadoola self-assigned this Oct 22, 2024
@Vadoola Vadoola added the bug Something isn't working label Oct 22, 2024
@Vadoola Vadoola added the wontfix This will not be worked on label Feb 13, 2025
@Vadoola
Copy link
Owner Author

Vadoola commented Feb 13, 2025

I think for now I will close this as wontfix. QET Elements and DXF files are going to have their differences, we can't possibly support all DXF features, take 3D DXF's for example. we can't make a 3d QET element, nor would it really make sense.

I'm not sure how used this bulge feature is, I had never even heard of it or come across it until I found this test file. For now I'm closing this, but if later down the road this starts causing some problems, or people submit DXFs that fail to convert correctly due to bulges, I'll reopen this issue.

@Vadoola Vadoola closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant