Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #337

Open
DrewKestell opened this issue Dec 1, 2021 · 1 comment
Open

[BUG] #337

DrewKestell opened this issue Dec 1, 2021 · 1 comment

Comments

@DrewKestell
Copy link

Details:
Jotunn Version: 2.4.1.0
Jotunn Submodule(if applicable):
Repeatability: Consistent(100%)

There's a bug in this code:

resourceName = resourceAssembly.GetManifestResourceNames().Single(str => str.EndsWith(bundleName));

Specifically, this line of code:
resourceName = resourceAssembly.GetManifestResourceNames().Single(str => str.EndsWith(bundleName));

I have two AssetBundles - daisy and pickable_daisy. When that code executes while trying to load daisy, Single() will throw an exception, and swallow that exception.

I would suggest doing some more intelligent string matching, probably by splitting on the . and retrieving the last segment.

Let me know if this repo is open to public contributions and I can submit a PR.

Thanks!

@joeyparrish
Copy link
Contributor

I believe they are open to contributions. I've had a good experience sending PRs so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants