Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Vue Router instances to global instance #27

Open
Venefilyn opened this issue Sep 4, 2018 · 0 comments
Open

Extract Vue Router instances to global instance #27

Venefilyn opened this issue Sep 4, 2018 · 0 comments
Labels
Front-end Issues for Vue, bundler, linter, styling.
Milestone
Redesign v3.0

Comments

@Venefilyn
Copy link
Member

Right now we use two Vue Router instances, in:

  • DisplayGuilds - for linking to config for Guild objects
  • EditGuild - for linking between component tabs

This should be changed to global Vue Router, specifically for /config, that uses history mode. Hopefully this should avoid hacks and improve test-ability.
@Venefilyn Venefilyn added the Front-end Issues for Vue, bundler, linter, styling. label Sep 4, 2018
@Venefilyn Venefilyn added this to the Redesign v3.0 milestone Sep 4, 2018
@Venefilyn Venefilyn mentioned this issue Sep 6, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Front-end Issues for Vue, bundler, linter, styling.
Projects
None yet
Milestone
Redesign v3.0
Development

No branches or pull requests
1 participant
@Venefilyn