proton: Fix a couple simple crashes #6633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice945
force-pushed
the
patch-1
branch
2 times, most recently
from
eeb91d4 to
c32e921
Compare
|
I assume this is an attempt to make Proton usable outside of Steam? I think it's a good thing overall. IMO we should reorganize code a bit:
|
ivyl
reviewed
Dec 13, 2023
| @@ -792,7 +792,7 @@ class CompatData: | |||
| os.symlink("/", self.prefix_dir + "/dosdevices/z:") | |||
|
|
|||
| # collect configuration info | |||
| steamdir = os.environ["STEAM_COMPAT_CLIENT_INSTALL_PATH"] | |||
| steamdir = os.environ.get("STEAM_COMPAT_CLIENT_INSTALL_PATH", "") | |||
There was a problem hiding this comment.
We depend on Steam setting up this variable and using [] will make this fail in a clear way if this ever regresses in Steam.
By doing .get() the way you do here we would silence this but also copying of the steam DLLs would silently fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash when no verb is provided due to accessing a nonexistent index in
sys.argv.Allows the
STEAM_COMPAT_CLIENT_INSTALL_PATHenvironment variable to not be set.