Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: rename some more groups settings API names #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lawlove
Copy link
Contributor

@lawlove lawlove commented Jan 30, 2015

(No logic changes)

The groups settings APIs were incorporating the extension "_used" in
APIs that indicate if the widget is "enabled" i.e., greyed out or not.

While reading some code in review, that term wasn't clear in
distinguishing it from the widget's "checked" or "selected" status. A
more apt name that would reflect its use better is "_able", i.e.,
instead of, e.g.,

m_defaults.state_render_used

using

m_defaults.state_render_able

would make for clearer reading of the code

Renamed these APIs using "_used" to "_able".

Signed-off-by: Lawrence L Love [email protected]

(No logic changes)

The groups settings APIs were incorporating the extension "_used" in
APIs that indicate if the widget is "enabled" i.e., greyed out or not.

While reading some code in review, that term wasn't clear in
distinguishing it from the widget's "checked" or "selected" status. A
more apt name that would reflect its use better is "_able", i.e.,
instead of, e.g.,

    m_defaults.state_render_used
using

    m_defaults.state_render_able

would make for clearer reading of the code

Renamed these APIs using "_used" to "_able".

Signed-off-by: Lawrence L Love <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant