-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetching Prisma Binary Fails due to an extra ' in the URL #5
Comments
@wxyangf Thanks for reporting this. It seems PNPM has a new Lockfile-Version 9, which stores the prisma version a bit differently from the previous version 6 that was used until PNPM 8.x. I'll have to add support for the new version first, which should be pretty simple. |
pnpm/spec#6 It's unfortunate that they haven't gotten around to writing the official spec page for it yet. I'll do some more research to try to discover if there's some well documented example files to test against at least. |
@wxyangf I don't think an official spec is necessary, it should be pretty simple to make a fix for PNPM 9. I'm not in a hurry with it, though, since PNPM9 seems not to be in nixpkgs yet. There's already an issue for this, though: NixOS/nixpkgs#312134 |
made a patch here, but only tested against lockfile v9 so far, will make a proper PR once i fully test |
@wxyangf I've made an update to support PNPM 9 Lockfiles. Can you check if it works for you? Thanks :) |
I'm closing this, because it seems to work at least for me and the company I work for. |
I'm trying to get a local dev enviroment for rx-resume which uses pnpm and when i run the flake with
nix shell .#devShells.x86_64-linux.default
I get this error message
here's the pnpm-lock.yml https://github.com/AmruthPillai/Reactive-Resume/blob/main/pnpm-lock.yaml
It seems when parsing out the prisma version it's getting an extra ' character appended to the commit hash.
I'm new to nixos so sorry if I'm missing anything obvious :P
Thanks in advance for looking at this.
The text was updated successfully, but these errors were encountered: