enchanted soil does not accelerate Dandelifeon #4405

Activity

1. ChickenDestroyer commented on Oct 6, 2023

   

   ChickenDestroyer

   on Oct 6, 2023

   More actions

   Any plans to fix?
2. williewillus

   assigned

   Alwinfy

   on Oct 6, 2023
3. KonSola5 commented on Nov 30, 2023

   

   KonSola5

   on Nov 30, 2023

   More actions

   Botania/Xplat/src/main/java/vazkii/botania/common/block/flower/generating/DandelifeonBlockEntity.java

   Line 61 in ed1d45e

   if (getLevel().getGameTime() % SPEED == 0 && getLevel().hasNeighborSignal(getBlockPos())) {

   Looks like the flower's speed is affected by game time (which is not boosted by overgrowth seed), not by the "ticksExisted".
4. Alwinfy commented on Nov 30, 2023

   

   Alwinfy

   on Nov 30, 2023

   Member

   More actions

   This is mostly inviable, since all Dandelifeon ticks are synchronized so that cells can cross boundaries.
   We could fix this by making accelerated and non-accelerated Dln. blocks incompatible...
5. TheRealWormbo commented on Dec 7, 2023

   

   TheRealWormbo

   on Dec 7, 2023

   Collaborator

   More actions

   Would it be reasonable to simply have them also process at % (SPEED/2) == 0 when on enchanted soil? I'd assume the logic that "imports" blocks from adjacent flowers could ignore any blocks that are associated with a flower that has a different enchanted soil state.
6. TheRealWormbo

   closed this as completedin #4660on Feb 8, 2025
7. TheRealWormbo

   closed this as completedin f5e8d72on Feb 8, 2025
8. TheRealWormbo

   added a commit that references this issue on Feb 10, 2025

   Update Dandelifeon to respect enchanted soil (VazkiiMods#4660)

   ...

   This issue will close once commit f5e8d72 is merged into the '1.20.x' branch.

   f5e8d72