added comment to launch and config. removed output to null.

Author: kohankhaki

templates/src/llm/finetune_distributed/config.yaml

@@ -2,19 +2,6 @@ defaults:
   - _global
   - _self_
 
-hydra:
-  job:
-    name: llm_finetune_distributed
-  searchpath:
-    - pkg://configs
-  launcher:
-    tasks_per_node: ${compute.gpus_per_node}
-    setup:
-      - 'export CUDA_VISIBLE_DEVICES=$SLURM_LOCALID'
-
-paths:
-  out_dir: null
-
 trainer:
   seed: 42
   model:
@@ -64,3 +51,12 @@ trainer:
       fsdp_min_num_params: 1000000
   logging:
     report_to: []
+
+hydra:
+  job:
+    name: llm_finetune_distributed
+  searchpath:
+    - pkg://configs  # Include configs from the configs package in the searchpath
+  launcher:
+    setup:
+      - 'export CUDA_VISIBLE_DEVICES=$SLURM_LOCALID'

templates/src/llm/finetune_distributed/launch.py

@@ -34,6 +34,7 @@ def main(cfg: DictConfig):
     OmegaConf.resolve(hydra_config)
     OmegaConf.save(hydra_config, save_path)
 
+    # Run the trainer with the run config
     trainer = FinetuneDistributedTrainer()
     return trainer(cfg)