Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metavar explanations are outdated #106

Open
Veykril opened this issue May 28, 2024 · 4 comments
Open

metavar explanations are outdated #106

Veykril opened this issue May 28, 2024 · 4 comments

Comments

@Veykril
Copy link
Owner

Veykril commented May 28, 2024

The counting order has been inversed recently I believe so the metavar section describes most metavars incorrectly now

@correabuscar
Copy link
Contributor

It's kinda odd how it sees it(there's one \n) (playground):

match (&compute_len("its input should somehow be self-referential, so let us make it return some\nninety-one!"),
            &Some(91)) {
        (left_val, right_val) => {
            if !(*left_val == *right_val) {
                    let kind = ::core::panicking::AssertKind::Eq;
                    ::core::panicking::assert_failed(kind, &*left_val,
                        &*right_val, ::core::option::Option::None);
                }
        }
    };

but in code it's

assert_eq!(
        call_a_or_b_on_tail!(
            (a: compute_len, b: show_tail),
            and now, to justify the existence of two paths
            we will also call a: its input should somehow
            be self-referential, so let us make it return
            some ninety-one!
        ),
        Some(91)
    );

@Veykril
Copy link
Owner Author

Veykril commented May 28, 2024

Oh interesting, the failure is not due tothe metavar changes, hmm wonder what changed there then

@Veykril
Copy link
Owner Author

Veykril commented May 28, 2024

This regressed in rust 1.76, will investigate. Neverheless, the issue here is still applicable, the explanations are outdated since rust-lang/rust#117050

@Veykril
Copy link
Owner Author

Veykril commented May 28, 2024

Right we are relying on the stringify output here which is not really specified so this is bound to occasionally break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants