Update charts/victoria-metrics-operator/CHANGELOG.md

Co-authored-by: Hui Wang <[email protected]>

Author: AndrewChubatiuk

charts/victoria-metrics-k8s-stack/values.yaml

@@ -26,8 +26,7 @@ argocdReleaseOverride: ""
 victoria-metrics-operator:
   enabled: true
   crds:
-    upgrade:
-      enabled: false
+    plain: true
     cleanup:
       enabled: true
       image:

charts/victoria-metrics-operator-crds/charts/crds/templates/crd.yaml

@@ -1,14 +1,11 @@
 {{- $files := .Files }}
-{{- $name := .Chart.Name }}
 {{- $crds := $files.Get "crd.yaml" | splitList "---" }}
 {{- $extra := dict "metadata" (dict "annotations" .Values.annotations "labels" .Values.labels) -}}
 {{- range $crds }}
   {{- $crd := merge (fromYaml .) $extra }}
-  {{- if hasPrefix $name $crd.metadata.name }}
-    {{- range $attrKey, $attrValue := $crd }}
-      {{- $attrKey }}: {{ toJson $attrValue }}
-      {{- printf "\n" -}}
-    {{ end }}
-    {{- print "\n---\n" }}
-  {{- end }}
+  {{- range $attrKey, $attrValue := $crd }}
+    {{- $attrKey }}: {{ toJson $attrValue }}
+    {{- printf "\n" -}}
+  {{ end }}
+  {{- print "\n---\n" }}
 {{- end }}

charts/victoria-metrics-operator-crds/values.yaml

@@ -1,11 +1,2 @@
-# -- operator common CRD annotations
-annotations: &annotations {}
-vm:
-  # -- Annotations for VM-prefixed CRDs
-  annotations: *annotations
-vl:
-  # -- Annotations for VL-prefixed CRDs
-  annotations: *annotations
-vt:
-  # -- Annotations for VT-prefixed CRDs
-  annotations: *annotations
+# -- VM operator CRD annotations
+annotations: {}

charts/victoria-metrics-operator/CHANGELOG.md

@@ -1,11 +1,11 @@
 ## Next release
 
-**Update note 1**: CRD template was replaced by CRD upgrade job. `Values.crds.plain` property was removed. Consider replacing it with `.Values.crds.upgrade.enabled: true` if automatic CRD upgrade is expected.
-**Update note 2**: Replaced `.Values.admissionWebhooks.enabledCRDValidation` map with `.Values.admissionWebhooks.disabledFor` list of CRD names to disable validation for.
+**Update node 1**: CRDs generated with `.Values.crds.plain: false` are now specless. For this case operator is fully responsible for VM specs validation. This was done to decrease helm release secret size limit. This change affects `kubectl explain` users and tools, that are rely on CRD specs during input data validation. If this behaviour is not acceptable consider using either `victoria-metrics-operator-crds` chart for CRDs management or set `.Values.crds.plain: true` to use plain CRDs.
 
 - Added `securityContext` to the `cleanup` job.
-- Removed `.Values.crds.plain` property, CRDs as templates are not supported by chart anymore. Added upgrade job instead, which is enabled by `.Values.crds.upgrade.enabled` property.
-- Replaced `.Values.admissionWebhooks.enabledCRDValidation` with `.Values.admissionWebhooks.disabledFor` list of CRD names to disable validation for.
+- Make CRDs, that are rendered using template, specless. This allows to decrease size of k8s secret significantly. If this option is not acceptable for you consider installing CRDs separately using `victoria-metrics-operator-crds` chart or set `.Values.crds.plain: true` and `.Values.crds.upgrade.enabled: true` to use plain CRDs with upgrade job instead.
+- Replaced `.Values.admissionWebhooks.enabledCRDValidation` with `.Values.admissionWebhooks.disabledFor` list of CRD names to disable validation for. This change should not affect anyone, since before condition with `.Values.admissionWebhooks.enabledCRDValidation` was not working at all.
+- Added CRDs upgrade job, which is only available only for plain CRDs (`.Values.crds.plain: true`). See [#2334](https://github.com/VictoriaMetrics/helm-charts/issues/2334).
 
 ## 0.53.0
 

charts/victoria-metrics-operator/Chart.yaml

@@ -6,7 +6,7 @@ home: https://github.com/VictoriaMetrics/operator
 sources:
   - https://github.com/VictoriaMetrics/helm-charts
   - https://github.com/VictoriaMetrics/operator
-version: 0.53.0
+version: 0.54.0
 appVersion: v0.63.0
 icon: https://avatars.githubusercontent.com/u/43720803?s=200&v=4
 kubeVersion: ">=1.25.0-0"
@@ -39,4 +39,4 @@ dependencies:
     repository: https://victoriametrics.github.io/helm-charts
   - name: crds
     version: "0.0.*"
-    condition: crds.enabled
+    condition: crds.plain