Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 当编辑状态退出前会validate验证,validate方法能否支持异步; #1797

Closed
creasy2010 opened this issue May 26, 2024 · 7 comments · Fixed by #2062
Closed
Labels
good first issue Good for newcomers

Comments

@creasy2010
Copy link
Contributor

What problem does this feature solve?

问题:
退出编辑前, 会进行数据验证, 但有些逻辑是异步(需要调用后端接口进行验证).
这样就会导致错误.

What does the proposed API look like?

validate 方法支持异步

@fangsmile fangsmile self-assigned this May 27, 2024
@fangsmile
Copy link
Contributor

收到。
这个需求的话 你要不要尝试帮我们改一下,做个代码贡献呢https://visactor.io/vtable/guide/Contribution_Guide @creasy2010

@creasy2010
Copy link
Contributor Author

可以.
只要这个需求跟之前的设计不冲突, 乐意处理

@fangsmile
Copy link
Contributor

飞书20240528-193336
可以加飞书群 加下我

@creasy2010
Copy link
Contributor Author

已修复, 在项目中测试, 测试通过后发去pr

@fangsmile
Copy link
Contributor

#1844. 为什么关闭了呢 @creasy2010

@fangsmile fangsmile added the good first issue Good for newcomers label Jun 13, 2024
@fangsmile fangsmile removed their assignment Jun 13, 2024
@fangsmile
Copy link
Contributor

#1844. 为什么关闭了呢 @creasy2010

@creasy2010

@creasy2010
Copy link
Contributor Author

creasy2010 commented Jun 16, 2024

@fangsmile 提交验证有些问题,
本周末上线, 线上验证完, 重新发pr
#1927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants