Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to accent color upon dynamic colors' unavailability #50

Open
VishnuSanal opened this issue Sep 22, 2023 · 0 comments
Open

Fallback to accent color upon dynamic colors' unavailability #50

VishnuSanal opened this issue Sep 22, 2023 · 0 comments
Labels
bug Something isn't working glitch A minor visual bug help wanted Extra attention is needed

Comments

@VishnuSanal
Copy link
Owner

Fallback to default DMP accent color (#E8374B) on A13 if dynamic colors are not generated. Currently it falls back to default color #6750A4. I tried setting colorPrimary on the theme, but seems like it doesn't work. DynamicColors#isDynamicColorAvailable simply returns true by checking API level & is not a valid enough way to check if dynamic colors are available or not. I have disabled dynamic colors on DMP for A12 for this issue. Labeling this as help-wanted, any help will be appreciated! 🙂
@VishnuSanal VishnuSanal added bug Something isn't working help wanted Extra attention is needed glitch A minor visual bug labels Sep 22, 2023
@VishnuSanal VishnuSanal changed the title Fallback to default color on A13 Fallback to accent color on A13 Sep 22, 2023
@VishnuSanal VishnuSanal changed the title Fallback to accent color on A13 Fallback to accent color upon dynamic colors' unavailability Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working glitch A minor visual bug help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VishnuSanal