Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While playing audio, changing the system theme causes the audio to stop playing. #51

Open
sameemul-haque opened this issue Oct 1, 2023 · 1 comment
Labels
area-playback Issues related to Playback bug Something isn't working

Comments

@sameemul-haque
Copy link
Contributor

sameemul-haque commented Oct 1, 2023

Describe the bug

While playing audio, changing the system theme causes the audio to stop playing.
Attempted to change the theme for the music player during audio playback by changing the system theme. The music player's theme successfully changed; however, I had to reopen the music player, and the audio playback was interrupted. Tested in two devices.

To Reproduce

  1. Play any audio using Dialog Music Player.
  2. Go to System Settings, and navigate to 'Display' or 'Themes.'
  3. Change the system theme to 'Dark' or 'Light.'
  4. Error: The audio stops playing.

Expected behavior

Audio playback should continue seamlessly even when changing the system theme.

Screenshots

  • I attempted to recreate this issue multiple times, and the following error message appeared:

Smartphone:

  • Device: Poco M2 Pro, Samsung Galaxy M33 5G
  • Android Version: Both Android 13
  • App Version: v2.1.1
@VishnuSanal VishnuSanal added bug Something isn't working area-playback Issues related to Playback labels Oct 1, 2023
@VishnuSanal
Copy link
Owner

VishnuSanal commented Oct 21, 2023

@sameemul-haque thank you for you descriptive bug report! this happens due to a workaround done to stop the music playing when the user quits the application. see: https://github.com/VishnuSanal/DialogMusicPlayer/blob/master/app/src/main/java/phone/vishnu/dialogmusicplayer/MainActivity.java#L222. there's no fix this this as of now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-playback Issues related to Playback bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants