Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close DMP after file finishes playing #55

Open
Cwpute opened this issue Oct 10, 2023 · 4 comments
Open

Close DMP after file finishes playing #55

Cwpute opened this issue Oct 10, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@Cwpute
Copy link

Cwpute commented Oct 10, 2023

Is your feature request related to a problem? Please describe.
A current bug makes DMP repeat playing the last played file after certain actions in other apps. This could be avoided if DMP wasn't running at all after it ended playing the lart file.

Also most of the time i don't find myself needing to play again files i previously listened to. Since my workflow implies switching apps and opening the top menu for the smartphone pretty often, i have to make with the passive dmp notification player taking a good bunch of space, and the app appearing in the Recent/Active Apps button (◻️ or ≡).
Closing the notification and app would do, but it would gelp having the app do it for me

Describe the solution you'd like
DMP should close altogether after the previous file finished playing. This could be an option.

Describe alternatives you've considered
It could close after a determinate amount of time (1 minute, 20 seconds, 10 seconds maybe) to allow the user to play it again.

Additional context
As DMP opens very fast, i don't see much drawbacks to this.
It probably will conflict with some people's workflow, hence the ability to make it an option.
This is mainly to circumvent the mentionned bug, but it would still be interesting as a feature.

@Cwpute
Copy link
Author

Cwpute commented Oct 10, 2023

sorry, i thought the app had been updated but it hasn't been. i am dumb ! and sorry.
See you in 2.1.2 :)

@Cwpute Cwpute closed this as completed Oct 10, 2023
@VishnuSanal
Copy link
Owner

@Cwpute No worries, appreciate the effort! :)

@Cwpute
Copy link
Author

Cwpute commented Dec 14, 2023

I am now using 2.1.2 and that issue is still there :/

@Cwpute Cwpute reopened this Dec 14, 2023
VishnuSanal added a commit that referenced this issue Dec 15, 2023
@VishnuSanal
Copy link
Owner

good suggestion, makes sense. let's remove DMP from recents 10 seconds after the track finishes playing.

marking this as a good first issue, since this is easy to implement :)

dev notes! stop MediaPlaybackService from MediaPlayer#OnCompletionListener by calling TransportControls#onStop after ten seconds.

@VishnuSanal VishnuSanal added the good first issue Good for newcomers label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants