Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency on swipe down to hide DMP #59

Open
Cwpute opened this issue Dec 14, 2023 · 1 comment
Open

Consistency on swipe down to hide DMP #59

Cwpute opened this issue Dec 14, 2023 · 1 comment
Labels
feature-request New feature or request good first issue Good for newcomers

Comments

@Cwpute
Copy link

Cwpute commented Dec 14, 2023

Is your feature request related to a problem? Please describe.
To hide DMP, you can use gestures and swipe down, but it only registers your swipe if the first swipe point is outside the app's window.
This becomes difficult to do when the music file you're opening has an image file attached (a cover) since you can only swipe on the outside of that image and tge app's window areas.

Describe the solution you'd like
Let the user swipe DMP down from anywhere on the screen, even when starting the swipe on the dialog window utself.

Describe alternatives you've considered
Since there is no actions related the cover picture (that i know of), let users swipe tge app down starting from inside the image's area.

Additional context
Add any other context or screenshots about the feature request here.

@Cwpute Cwpute changed the title Swipe down to charge apps Consistency on swipe down to hide DMP Dec 14, 2023
@VishnuSanal
Copy link
Owner

To hide DMP, you can use gestures and swipe down, but it only registers your swipe if the first swipe point is outside the app's window. This becomes difficult to do when the music file you're opening has an image file attached (a cover) since you can only swipe on the outside of that image and tge app's window areas.

this is not a bug, but a feature! I spend a good hour or so implementing this 🙂

Let the user swipe DMP down from anywhere on the screen, even when starting the swipe on the dialog window utself.

but yes, it makes sense to add swipe gestures to hide the app.

marking this as a good first issue. person implementing can modify this accordingly & assign the listener to the root view.

@VishnuSanal VishnuSanal added feature-request New feature or request good first issue Good for newcomers labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants