Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate PDF for an article with two or more versions #85

Open
eddoff opened this issue Mar 28, 2023 · 7 comments
Open

generate PDF for an article with two or more versions #85

eddoff opened this issue Mar 28, 2023 · 7 comments

Comments

@eddoff
Copy link

eddoff commented Mar 28, 2023

I tried to generrate PDF for an article that had two active versions (I am using OJS 3.3.0.13).

I was going to "fulltext" tab for the old version of the article, and tried to generate a PDF for that. However, no PDF was generated for this version. But when switching to the new version another PDF has been generated there instead. The metadata (issue name, year and number) from the new version appeard in the header of the PDF.

I hope you can solve this issue. We are publishing in an "online-first"-manner where the issue is changing from this online-first-issue to an archived version when the year has ended. So this issue affects all articles in the journal.

Best regards.

@Vitaliy-1
Copy link
Owner

Vitaliy-1 commented Mar 31, 2023

Thanks, @eddoff

Can you check if this commit fixes the issue: 6a17ff5?

@eddoff
Copy link
Author

eddoff commented Apr 17, 2023

It does not seem to work, unfortunately.

@Vitaliy-1
Copy link
Owner

@eddoff, this data is passed to the browser, make sure that the JS cache is cleared.

@eddoff
Copy link
Author

eddoff commented Apr 18, 2023

I have cleared the cache both of the browser and OJS. The PDF is generated in the correct version now, but still the issue name and number of the other version of the article is included in the PDF.

@Vitaliy-1
Copy link
Owner

but still the issue name and number of the other version of the article is included in the PDF

To fix this part, apply additionally this commit: 7cb50cb

@eddoff
Copy link
Author

eddoff commented Apr 18, 2023

Great, it works! Thanks! When do you plan to publish a new version of the plugin?

@Vitaliy-1
Copy link
Owner

After new OJS release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants