Bug/eventurl as array (#252)

Fix Connect action eventUrl

* `eventUrl` should be an array, not string
* Updated tests for having Connect event URL be an array
* Added changelog for 2.3.3

Co-authored-by: Abel Ng <[email protected]>

Author: dragonmantank

CHANGELOG.md

@@ -1,3 +1,9 @@
+# 2.3.3
+
+### Fixed
+
+* #252 - Connect action's `eventUrl` was being set as a string, changed to single element array of strings
+
 # 2.3.2
 
 ### Added

src/Voice/NCCO/Action/Connect.php

@@ -101,7 +101,7 @@ public function toNCCOArray(): array
 
         $eventWebhook = $this->getEventWebhook();
         if ($eventWebhook) {
-            $data['eventUrl'] = $eventWebhook->getUrl();
+            $data['eventUrl'] = [$eventWebhook->getUrl()];
             $data['eventMethod'] = $eventWebhook->getMethod();
         }
 

test/Voice/NCCO/Action/ConnectTest.php

@@ -85,7 +85,7 @@ public function testGeneratesCorrectNCCOArray()
         $this->assertSame(6000, $ncco['limit']);
         $this->assertSame('https://test.domain/ringback.mp3', $ncco['ringbackTone']);
         $this->assertSame(10, $ncco['timeout']);
-        $this->assertSame('https://test.domain/events', $ncco['eventUrl']);
+        $this->assertSame(['https://test.domain/events'], $ncco['eventUrl']);
         $this->assertSame('POST', $ncco['eventMethod']);
     }
 
@@ -112,7 +112,7 @@ public function testJSONSerializesToCorrectStructure()
         $this->assertSame(6000, $ncco['limit']);
         $this->assertSame('https://test.domain/ringback.mp3', $ncco['ringbackTone']);
         $this->assertSame(10, $ncco['timeout']);
-        $this->assertSame('https://test.domain/events', $ncco['eventUrl']);
+        $this->assertSame(['https://test.domain/events'], $ncco['eventUrl']);
         $this->assertSame('POST', $ncco['eventMethod']);
     }