Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "database" in config for mysql connections #161

Open
4Kaylum opened this issue Jan 22, 2022 · 5 comments · May be fixed by #166
Open

Allow "database" in config for mysql connections #161

4Kaylum opened this issue Jan 22, 2022 · 5 comments · May be fixed by #166
Labels
enhancement New feature or request

Comments

@4Kaylum
Copy link
Member

4Kaylum commented Jan 22, 2022

Aiomysql requires "db" instead of "database". VBU should allow both.

@Crafter-san
Copy link
Contributor

Aiomysql requires "db" instead of "database". VBU should allow both.

I will try my best to see what I can do for that

@Crafter-san
Copy link
Contributor

Crafter-san commented Mar 8, 2022

@4Kaylum when you're awake, please elaborate on which part it requires "database". Are you talking about item names in objects sent to the API? or are you talking about variables?

@sn8to
Copy link
Contributor

sn8to commented Mar 9, 2022

The current VBU config file takes in database connection options with the "database" key. The "db" key should be considered an alias/alternative to this key.

If both are supplied, which one should take over the other?

@sn8to sn8to added the enhancement New feature or request label Mar 9, 2022
@Silverdimond
Copy link

Silverdimond commented Mar 9, 2022

The current VBU config file takes in database connection options with the "database" key. The "db" key should be considered an alias/alternative to this key.

If both are supplied, which one should take over the other?

Ideally, the last one that is defined in a file so they would overwrite each other but maybe "database" if checking for the last one in a file is not a possibility as "database" is just longer and more noticeable in a large configuration file.
I would love to know what your opinions are and the justifications behind those opinions

@4Kaylum
Copy link
Member Author

4Kaylum commented Mar 9, 2022

honestly the config should just stay as only allowing "database" and just parse it differently for msql connections

iHeroGH added a commit to iHeroGH/VoxelBotUtils that referenced this issue May 31, 2023
Fixes Voxel-Fox-Ltd#161 

I'm unsure if `del`eting the old key will have unintended consequences...
@iHeroGH iHeroGH linked a pull request May 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants