[fix][refactors]: Fix taint issues related UIDropDownMenu api usage
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juemrami
force-pushed
the
hotfix_dropdown_taint_issues
branch
from
0c7d187 to
ee49e4d
Compare
- removes usage of deprecated UIDropDownMenu api - this change should prevent (at least) settings panel dropdowns from tainting ui
juemrami
force-pushed
the
hotfix_dropdown_taint_issues
branch
from
ee49e4d to
ea7c586
Compare
…ed DropDownList buttons - This prevents any taint error that could be induced by us not using the UIDropDownMenu API correctly. - This is a temporary solution to rewriting the whole `Tool.CreatePopup` system to support the new menuGenerator APIs.
juemrami
force-pushed
the
hotfix_dropdown_taint_issues
branch
from
ea7c586 to
8f4b342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
[refactor]: migrate settings panel dropdowns to the new dropdown api
[refactor]: migrate announcement channel selection dropdown to new API
[refactor][hotfix]: implement
TaintLess.xmlstyle cleanup for touched DropDownList buttonsTaintLess.xmllibrary #344UIDropDownMenu.Tool.CreatePopupsystem to support the new menuGenerator APIs.PopupDyanmicframe is hard to re-create using the new API's because they dont support Right Clicks.