-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make inplace_function SFINAE aware #155
Make inplace_function SFINAE aware #155
Conversation
26fd931
to
94debf7
Compare
I force pushed some indentations fixes, can someone re trigger the CI. |
(Force-pushed to your feature branch, I assume and hope. ;)) My understanding is that GitHub will notice and re-trigger the Travis CI build on its own, relatively quickly, any time the tip of the feature branch changes. Whether the history "changed" or just "incremented" doesn't matter to GitHub. EDIT: oh, I get it. If the branch is at one SHA when the CI is triggered, and then that SHA disappears from GitHub before the CI actually runs, the CI job errors out. That makes sense. And I think I found a "Restart build" button. :) |
04d4075
to
25a4746
Compare
Ok, that should address your last comment regarding the conversion tests. I went with a hybrid approach, that should catch most problems, and added some additional closure type tests. |
25a4746
to
e08c83f
Compare
Friendly ping, is there something blocking this? |
e08c83f
to
cdbe652
Compare
It feels like this pr is spiraling out of scope. Given that the remaining problems exist on master and are somewhat unrelated to the changes in this pr, I'd suggest merging this as is and addressing #125 in a separate pr. |
cdbe652
to
0ba78c1
Compare
rebase @Quuxplusone ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo these remaining comments.
0ba78c1
to
4544736
Compare
4544736
to
62ad577
Compare
friendly ping @Quuxplusone |
@Quuxplusone @p-groarke this should address the issues described in #149.
I went with a custom implementation of
std::is_invocable_r
, because the standard versions don't seem to respect return types, and there seem to be pre C++17 users of this library.