From c6f319d7254f7e27ebf5ab4f99a8fb0c2414667a Mon Sep 17 00:00:00 2001 From: WHAHA-HA Date: Tue, 2 Feb 2021 12:36:17 +0530 Subject: [PATCH] Finalized Repository --- .gitignore | 1 - CONTRIBUTING.md | 17 ++++++++--------- LICENSE | 2 +- README.md | 8 ++++---- Solutions/364.py | 4 ++-- requirements.txt | Bin 100 -> 104 bytes 6 files changed, 15 insertions(+), 17 deletions(-) diff --git a/.gitignore b/.gitignore index 5d5431b..fb47e28 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,4 @@ # Byte-compiled / optimized / DLL files -Solutions/DataStructures/__pycache__ __pycache__/* *.py[cod] *.pyo diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 335be87..db08ac0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -14,32 +14,31 @@ contributors, you agree and confirm that: - Your work will be distributed under [MIT License](LICENSE.md) once your pull request is merged. -- You submitted work fulfils the styles and standards of this repository. +- You submitted work fulfills the styles and standards of this repository. ### Contribution -Any contribution, from fixing a grammatical mistake in a comment to improvising current +Any contribution, from fixing a grammatical errors in a comment to improvising current solutions is appriciated. **New implementation** is welcome as long as the solution improvises the `Time Complexity` and/or `Space Complexity` without deteriorating the either of them -compared to the current solution! But **identical implementation** of an existing -solution is not allowed. +compared to the current solution. But **identical implementation** of an existing +solution will not be accepted. **Improving comments** are also highly welcome. But **fake pull requests**, like -_unnecessarily changing the wording or adding 'a' or 'the', are highly discouraged_. +_unnecessarily changing the wording, adding 'a' or 'the', etc_ are highly discouraged. Such pull requests will be closed immediately and labeled as `invalid`. ### Other Requirements for Submissions - Use [black](https://pypi.org/project/black/) to format you code. -- Strictly use **PascalCase** for class names and**snake_case** in your variable and +- Strictly use **PascalCase** for class names and **snake_case** in your variable and function names. -- If you have modified/added code work, make sure the code compiles before - submitting. - If you have modified/added documentation work, ensure your language is concise and contains no grammatical errors. -- Do not update the README.md file. +- If you have modified/added code work, make sure the code compiles before + submitting. - Make sure to add [**Python type hints**](https://docs.python.org/3/library/typing.html) to all functions and methods. diff --git a/LICENSE b/LICENSE index 6a2ce18..a69e6b7 100644 --- a/LICENSE +++ b/LICENSE @@ -1,6 +1,6 @@ MIT License -Copyright (c) 2019 Tapajyoti Bose +Copyright (c) 2021 Tapajyoti Bose Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal diff --git a/README.md b/README.md index 0689cb5..d0b6250 100644 --- a/README.md +++ b/README.md @@ -2,10 +2,6 @@ This repository contains the **[Daily Coding Problem](https://www.dailycodingproblem.com)** solutions in python. -## Contribution Guidelines - -Read our [Contribution Guidelines](CONTRIBUTING.md) before you contribute. - ## Setup Install the 3rd party packages, perform the following steps: @@ -13,6 +9,10 @@ Install the 3rd party packages, perform the following steps: 1. `cd Daily-Coding-Challenge-Solutions` 2. Run `pip install -r requirements.txt` +## Contribution Guidelines + +Please go through [Contribution Guidelines](CONTRIBUTING.md) before you contribute. + ## Note: 1. Modules `numpy` and `matplotlib` are used for presentation purpose only and hence are optional. diff --git a/Solutions/364.py b/Solutions/364.py index 4eeae33..9691e29 100644 --- a/Solutions/364.py +++ b/Solutions/364.py @@ -33,8 +33,8 @@ def get_longest_increasing_subsequence(arr: List[int]) -> int: tail_table[result_length] = arr[i] result_length += 1 else: - # current element is the last candidate of an existing subsequence. - # it will replace ceil value in tail_table + # current element is the last candidate of an existing subsequence and will + # replace ceil value in tail_table tail_table[get_ceil_index(tail_table, -1, result_length - 1, arr[i])] = arr[ i ] diff --git a/requirements.txt b/requirements.txt index 20f820fb957467ee79e6c3ebf9ab6b50694e771b..3a26d19f3b25511a6fc7e733b60dcffce9b218be 100644 GIT binary patch delta 9 QcmYevn2^H4%fQ6|01a^g+yDRo delta 4 Lcmc~unUDei1XKaR