From 849438190777d7a325d0461b661b35b62ad5c9c4 Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Wed, 7 Aug 2024 13:08:03 +1000 Subject: [PATCH 01/10] Add provider validation --- index.html | 38 ++++++++++++++++++++++++++++++++++---- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/index.html b/index.html index 7b9223f..e196900 100644 --- a/index.html +++ b/index.html @@ -294,6 +294,29 @@

  • If |providers| is empty, [=exception/throw=] a {{TypeError}}.
    • +
  • [=List/For each=] |provider| in |providers|: +
      +
    1. If |provider|'s {{DigitalCredentialsProvider/protocol}} is does + not match a [=digital credentials registry/protocol identifier=] from + the [=digital credentials registry=], [=exception/throw=] a + {{TypeError}}. +
      2. +
    2. Let |dictionary| be the [=digital credentials registry/Web IDL + dictionary=] for |provider|'s + {{DigitalCredentialsProvider/protocol}}. +
      3. +
    3. Let |request| be |provider|'s + {{DigitalCredentialsProvider/request}} [=converted to an idl + value|converted=] to |dictionary|. [=exception/throw|Rethrow=] any + exceptions. +
      4. +
    4. Validate |request| against any validation rules set forth in the + corresponding [=digital credentials registry/specification=]. If any + of |request|'s members are invalid, [=exception/throw=] a + {{TypeError}}. +
      5. +
    +
  • [=List/For each=] |provider| in |providers|:
      -
    1. If |provider|'s {{DigitalCredentialsProvider/protocol}} is does +
    2. If |provider|'s {{DigitalCredentialsProvider/protocol}} does not match a [=digital credentials registry/protocol identifier=] from the [=digital credentials registry=], [=exception/throw=] a {{TypeError}}. From a97491b96295d65883622f07ddb4face33764ffc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Tue, 13 Aug 2024 16:12:25 +1000 Subject: [PATCH 05/10] Update index.html Co-authored-by: Ted Thibodeau Jr --- index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 0f1f027..b0e617e 100644 --- a/index.html +++ b/index.html @@ -389,8 +389,8 @@

      Registry of protocols for requesting digital credential

      - The following are digital - credentials registry exchange protocols supported by + The following are exchange + protocols from the digital credentials registry, supported by this specification.

      From ae32976fa38e9df3c7a6c89aee82f91219da92f6 Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Tue, 13 Aug 2024 16:33:06 +1000 Subject: [PATCH 06/10] Use range and index correctly --- index.html | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/index.html b/index.html index b0e617e..23140f9 100644 --- a/index.html +++ b/index.html @@ -292,13 +292,18 @@

    3. Let |providers| be |options|'s {{CredentialRequestOptions/digital}}'s {{DigitalCredentialRequestOptions/providers}} member.
      4. -
    4. If |providers| is empty, [=exception/throw=] a {{TypeError}}. +
    5. If |providers| [=list/is empty=], [=exception/throw=] a + {{TypeError}}.
      6. -
    6. [=List/For each=] |provider| in |providers|: +
    7. Let |range| be [=list/get the indices=] of |providers|. +
      8. +
    8. [=For each=] |n| of the |range|:
        -
      1. If |provider|'s {{DigitalCredentialsProvider/protocol}} does - not match a [=digital credentials registry/protocol identifier=] from - the [=digital credentials registry=], [=exception/throw=] a +
      2. Let |provider| be [=list/item=] at |providers|'s |n| index. +
        3. +
      3. If |provider|'s {{DigitalCredentialsProvider/protocol}} does not + match a [=digital credentials registry/protocol identifier=] from the + [=digital credentials registry=], [=exception/throw=] a {{TypeError}}.
      4. Let |dictionary| be the [=digital credentials registry/Web IDL @@ -315,6 +320,9 @@

        of |request|'s members are invalid, [=exception/throw=] a {{TypeError}}.

        5. +
      5. Set [=list/item=] at |providers|'s |n| index's + {{DigitalCredentialsProvider/request}} to |request|. +
    9. @@ -390,8 +398,8 @@

      The following are exchange - protocols from the digital credentials registry, supported by - this specification. + protocols from the digital credentials registry, supported by this + specification.

      It is expected that this registry will be become a [=W3C registry=] in From 62fdfc383742d3bf2027a65560b509721593ecf4 Mon Sep 17 00:00:00 2001 From: Marcos Caceres Date: Tue, 13 Aug 2024 16:40:22 +1000 Subject: [PATCH 07/10] it's a set --- index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.html b/index.html index 23140f9..6972f6d 100644 --- a/index.html +++ b/index.html @@ -297,7 +297,7 @@

    10. Let |range| be [=list/get the indices=] of |providers|.
      11. -
    11. [=For each=] |n| of the |range|: +
    12. [=Set/For each=] |n| of the |range|:
      1. Let |provider| be [=list/item=] at |providers|'s |n| index.
        2. From 41e3dd47a97ad881bcfa2b2dc131061054376f55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Wed, 14 Aug 2024 07:58:23 +1000 Subject: [PATCH 08/10] Update index.html --- index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.html b/index.html index 6972f6d..d61bd9d 100644 --- a/index.html +++ b/index.html @@ -295,7 +295,7 @@

      2. If |providers| [=list/is empty=], [=exception/throw=] a {{TypeError}}.
        3. -
      3. Let |range| be [=list/get the indices=] of |providers|. +
      4. Let |range| be [=list/get the indices|the indices=] of |providers|.
      5. [=Set/For each=] |n| of the |range|:
          From 51d71125663f33034041bbe30ff462e02b65f000 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Wed, 14 Aug 2024 07:58:55 +1000 Subject: [PATCH 09/10] Update index.html Co-authored-by: Ted Thibodeau Jr --- index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.html b/index.html index d61bd9d..3301df0 100644 --- a/index.html +++ b/index.html @@ -299,7 +299,7 @@

        1. [=Set/For each=] |n| of the |range|:
            -
          1. Let |provider| be [=list/item=] at |providers|'s |n| index. +
          2. Let |provider| be the [=list/item=] at |providers|'s |n| index.
          3. If |provider|'s {{DigitalCredentialsProvider/protocol}} does not match a [=digital credentials registry/protocol identifier=] from the From f87ba1e577c3c803f8563026aa0ea1a9d53f1a74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcos=20C=C3=A1ceres?= Date: Wed, 14 Aug 2024 07:59:46 +1000 Subject: [PATCH 10/10] Update index.html Co-authored-by: Ted Thibodeau Jr --- index.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/index.html b/index.html index 3301df0..6a938ef 100644 --- a/index.html +++ b/index.html @@ -397,9 +397,9 @@

            Registry of protocols for requesting digital credential

            - The following are exchange - protocols from the digital credentials registry, supported by this - specification. + The following exchange + protocols from the digital credentials registry are supported by + this specification.

            It is expected that this registry will be become a [=W3C registry=] in