From 8bf3fb78a4f00a5557c65fbaa051ebf7b4590520 Mon Sep 17 00:00:00 2001 From: malavikakoppula <83021791+malavikakoppula@users.noreply.github.com> Date: Tue, 12 Dec 2023 10:54:34 -0500 Subject: [PATCH] [THEMES-1214] Implemented logical properties on Share-bar-block (#1844) * Implemented logical properties * Updated border properties --------- Co-authored-by: Malavika Koppula --- .storybook/themes/news.scss | 19 ++++++++++++++----- blocks/share-bar-block/index.story.mdx | 21 +++++++++++++++++++++ blocks/share-bar-block/themes/news.json | 24 ++++++++++++++++++------ 3 files changed, 53 insertions(+), 11 deletions(-) diff --git a/.storybook/themes/news.scss b/.storybook/themes/news.scss index e67a89ba88..647569e555 100644 --- a/.storybook/themes/news.scss +++ b/.storybook/themes/news.scss @@ -2556,19 +2556,28 @@ "border-radius": 0 var(--border-radius) var(--border-radius) 0, "display": none, "gap": var(--global-spacing-2), - "left": 0, - "padding": var(--global-spacing-4) 0, + "inset-block-start": 200px, + "inset-inline-start": 0, + "padding-block-end": var(--global-spacing-4), + "padding-block-start": var(--global-spacing-4), + "padding-inline-end": 0, + "padding-inline-start": 0, "position": fixed, - "top": 200px, "components": ( "button": ( "background-color": transparent ), "button-default": ( - "border-width": 0 + "border-block-end-width": 0, + "border-block-start-width": 0, + "border-inline-end-width": 0, + "border-inline-start-width": 0 ), "button-medium": ( - "padding": 0 var(--global-spacing-3) + "padding-block-end": 0, + "padding-block-start": 0, + "padding-inline-end": var(--global-spacing-3), + "padding-inline-start": var(--global-spacing-3) ) ) ), diff --git a/blocks/share-bar-block/index.story.mdx b/blocks/share-bar-block/index.story.mdx index cc7ae9ec7f..77151ff478 100644 --- a/blocks/share-bar-block/index.story.mdx +++ b/blocks/share-bar-block/index.story.mdx @@ -91,3 +91,24 @@ const AnotherComponentWithGlobalContent = () => ; /> + +** With RTL ** + +
+ + key }} + /> + +
diff --git a/blocks/share-bar-block/themes/news.json b/blocks/share-bar-block/themes/news.json index 280c76689f..b6785e5374 100644 --- a/blocks/share-bar-block/themes/news.json +++ b/blocks/share-bar-block/themes/news.json @@ -4,22 +4,34 @@ "default": { "background": "var(--background-color)", "box-shadow": "var(--global-box-shadow-1)", - "border-radius": "0 var(--border-radius) var(--border-radius) 0", + "border-start-start-radius": "0", + "border-start-end-radius": "var(--border-radius)", + "border-end-end-radius": "var(--border-radius)", + "border-end-start-radius": "0", "display": "none", "gap": "var(--global-spacing-2)", - "left": 0, - "padding": "var(--global-spacing-4) 0", + "inset-block-start": "200px", + "inset-inline-start": 0, + "padding-block-end": "var(--global-spacing-4)", + "padding-block-start": "var(--global-spacing-4)", + "padding-inline-end": "0", + "padding-inline-start": "0", "position": "fixed", - "top": "200px", "components": { "button": { "background-color": "transparent" }, "button-default": { - "border-width": 0 + "border-block-end-width": "0", + "border-block-start-width": "0", + "border-inline-end-width": "0", + "border-inline-start-width": "0" }, "button-medium": { - "padding": "0 var(--global-spacing-3)" + "padding-block-end": "0", + "padding-block-start": "0", + "padding-inline-end": "var(--global-spacing-3)", + "padding-inline-start": "var(--global-spacing-3)" } } },