From 97de62cd02b493967bf9359542e5c2db8aa783fc Mon Sep 17 00:00:00 2001 From: blakeganderson <85515364+blakeganderson@users.noreply.github.com> Date: Fri, 22 Dec 2023 16:36:15 -0500 Subject: [PATCH] added logical properties to identity blocks (#1862) --- blocks/identity-block/themes/commerce.json | 27 +++++++++++----------- blocks/identity-block/themes/news.json | 27 +++++++++++----------- 2 files changed, 28 insertions(+), 26 deletions(-) diff --git a/blocks/identity-block/themes/commerce.json b/blocks/identity-block/themes/commerce.json index afdf4dc93e..82b1ed1fc2 100644 --- a/blocks/identity-block/themes/commerce.json +++ b/blocks/identity-block/themes/commerce.json @@ -13,8 +13,7 @@ }, "heading": { "font-size": "var(--global-font-size-7)", - "margin-block-end": "var(--global-spacing-2)", - "margin-bottom": "var(--global-spacing-2)" + "margin-block-end": "var(--global-spacing-2)" }, "input": { "margin-block-end": "var(--global-spacing-5)" @@ -24,7 +23,6 @@ }, "input-input": { "inline-size": "100%", - "width": "100%", "padding-block-end": "var(--global-spacing-2)", "padding-block-start": "var(--global-spacing-2)" }, @@ -116,7 +114,6 @@ "border-block-end-width": "var(--global-border-width-1)", "font-size": "var(--global-font-size-9)", "margin-block-end": "var(--global-spacing-4)", - "margin-bottom": "var(--global-spacing-4)", "padding-block-end": "var(--global-spacing-2)", "text-align": "center" }, @@ -128,7 +125,6 @@ }, "input-input": { "inline-size": "100%", - "width": "100%", "padding-block-end": "var(--global-spacing-2)", "padding-block-start": "var(--global-spacing-2)" }, @@ -188,14 +184,25 @@ "header-account-action-dropdown-open": { "styles": { "default": { - "top": "100%", + "inset-block-start": "100%", "position": "absolute", "padding-block-end": "var(--global-spacing-4)", "padding-block-start": "var(--global-spacing-4)", "padding-inline-end": "var(--global-spacing-4)", "padding-inline-start": "var(--global-spacing-4)", "background-color": "var(--global-white)", - "border": "1px solid var(--border-color)", + "border-block-start-width": "1px", + "border-block-end-width": "1px", + "border-inline-start-width": "1px", + "border-inline-end-width": "1px", + "border-block-start-style": "solid", + "border-block-end-style": "solid", + "border-inline-start-style": "solid", + "border-inline-end-style": "solid", + "border-block-start-color": "var(--border-color)", + "border-block-end-color": "var(--border-color)", + "border-inline-start-color": "var(--border-color)", + "border-inline-end-color": "var(--border-color)", "border-radius": "var(--global-spacing-1)", "box-shadow": "0 0 4px 0 rgba(0, 0, 0, 0.25)", "display": "flex", @@ -243,7 +250,6 @@ "border-block-end-width": "var(--global-border-width-1)", "font-size": "var(--global-font-size-9)", "margin-block-end": "var(--global-spacing-4)", - "margin-bottom": "var(--global-spacing-4)", "padding-block-end": "var(--global-spacing-2)", "text-align": "center" }, @@ -255,7 +261,6 @@ }, "input-input": { "inline-size": "100%", - "width": "100%", "padding-block-end": "var(--global-spacing-2)", "padding-block-start": "var(--global-spacing-2)" }, @@ -304,7 +309,6 @@ "border-block-end-width": "var(--global-border-width-1)", "font-size": "var(--global-font-size-9)", "margin-block-end": "var(--global-spacing-4)", - "margin-bottom": "var(--global-spacing-4)", "padding-block-end": "var(--global-spacing-2)", "text-align": "center" }, @@ -316,7 +320,6 @@ }, "input-input": { "inline-size": "100%", - "width": "100%", "padding-block-end": "var(--global-spacing-2)", "padding-block-start": "var(--global-spacing-2)" }, @@ -351,7 +354,6 @@ "border-block-end-width": "var(--global-border-width-1)", "font-size": "var(--global-font-size-9)", "margin-block-end": "var(--global-spacing-4)", - "margin-bottom": "var(--global-spacing-4)", "padding-block-end": "var(--global-spacing-2)", "text-align": "center" }, @@ -363,7 +365,6 @@ }, "input-input": { "inline-size": "100%", - "width": "100%", "padding-block-end": "var(--global-spacing-2)", "padding-block-start": "var(--global-spacing-2)" }, diff --git a/blocks/identity-block/themes/news.json b/blocks/identity-block/themes/news.json index afdf4dc93e..82b1ed1fc2 100644 --- a/blocks/identity-block/themes/news.json +++ b/blocks/identity-block/themes/news.json @@ -13,8 +13,7 @@ }, "heading": { "font-size": "var(--global-font-size-7)", - "margin-block-end": "var(--global-spacing-2)", - "margin-bottom": "var(--global-spacing-2)" + "margin-block-end": "var(--global-spacing-2)" }, "input": { "margin-block-end": "var(--global-spacing-5)" @@ -24,7 +23,6 @@ }, "input-input": { "inline-size": "100%", - "width": "100%", "padding-block-end": "var(--global-spacing-2)", "padding-block-start": "var(--global-spacing-2)" }, @@ -116,7 +114,6 @@ "border-block-end-width": "var(--global-border-width-1)", "font-size": "var(--global-font-size-9)", "margin-block-end": "var(--global-spacing-4)", - "margin-bottom": "var(--global-spacing-4)", "padding-block-end": "var(--global-spacing-2)", "text-align": "center" }, @@ -128,7 +125,6 @@ }, "input-input": { "inline-size": "100%", - "width": "100%", "padding-block-end": "var(--global-spacing-2)", "padding-block-start": "var(--global-spacing-2)" }, @@ -188,14 +184,25 @@ "header-account-action-dropdown-open": { "styles": { "default": { - "top": "100%", + "inset-block-start": "100%", "position": "absolute", "padding-block-end": "var(--global-spacing-4)", "padding-block-start": "var(--global-spacing-4)", "padding-inline-end": "var(--global-spacing-4)", "padding-inline-start": "var(--global-spacing-4)", "background-color": "var(--global-white)", - "border": "1px solid var(--border-color)", + "border-block-start-width": "1px", + "border-block-end-width": "1px", + "border-inline-start-width": "1px", + "border-inline-end-width": "1px", + "border-block-start-style": "solid", + "border-block-end-style": "solid", + "border-inline-start-style": "solid", + "border-inline-end-style": "solid", + "border-block-start-color": "var(--border-color)", + "border-block-end-color": "var(--border-color)", + "border-inline-start-color": "var(--border-color)", + "border-inline-end-color": "var(--border-color)", "border-radius": "var(--global-spacing-1)", "box-shadow": "0 0 4px 0 rgba(0, 0, 0, 0.25)", "display": "flex", @@ -243,7 +250,6 @@ "border-block-end-width": "var(--global-border-width-1)", "font-size": "var(--global-font-size-9)", "margin-block-end": "var(--global-spacing-4)", - "margin-bottom": "var(--global-spacing-4)", "padding-block-end": "var(--global-spacing-2)", "text-align": "center" }, @@ -255,7 +261,6 @@ }, "input-input": { "inline-size": "100%", - "width": "100%", "padding-block-end": "var(--global-spacing-2)", "padding-block-start": "var(--global-spacing-2)" }, @@ -304,7 +309,6 @@ "border-block-end-width": "var(--global-border-width-1)", "font-size": "var(--global-font-size-9)", "margin-block-end": "var(--global-spacing-4)", - "margin-bottom": "var(--global-spacing-4)", "padding-block-end": "var(--global-spacing-2)", "text-align": "center" }, @@ -316,7 +320,6 @@ }, "input-input": { "inline-size": "100%", - "width": "100%", "padding-block-end": "var(--global-spacing-2)", "padding-block-start": "var(--global-spacing-2)" }, @@ -351,7 +354,6 @@ "border-block-end-width": "var(--global-border-width-1)", "font-size": "var(--global-font-size-9)", "margin-block-end": "var(--global-spacing-4)", - "margin-bottom": "var(--global-spacing-4)", "padding-block-end": "var(--global-spacing-2)", "text-align": "center" }, @@ -363,7 +365,6 @@ }, "input-input": { "inline-size": "100%", - "width": "100%", "padding-block-end": "var(--global-spacing-2)", "padding-block-start": "var(--global-spacing-2)" },