From 36255ab7b9bb3f8ecdfe3c922e8e5617f3aba2c0 Mon Sep 17 00:00:00 2001
From: blakeganderson <85515364+blakeganderson@users.noreply.github.com>
Date: Tue, 12 Dec 2023 13:32:27 -0500
Subject: [PATCH 1/2] added logical properties to add block

---
 .storybook/themes/news.scss           |  7 +++++--
 blocks/ads-block/index.story.jsx      | 12 ++++++++++++
 blocks/ads-block/themes/commerce.json |  7 +++++--
 blocks/ads-block/themes/news.json     |  7 +++++--
 4 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/.storybook/themes/news.scss b/.storybook/themes/news.scss
index 647569e555..723a9284a0 100644
--- a/.storybook/themes/news.scss
+++ b/.storybook/themes/news.scss
@@ -272,12 +272,15 @@
 				),
 				"ads-block-admin": (
 					"background-color": "$global.neutral-7",
-					"padding": "$global.spacing-4",
+					"padding-block-start": "$global.spacing-4",
+					"padding-inline-end": "$global.spacing-4",
+					"padding-block-end": "$global.spacing-4",
+					"padding-inline-start": "$global.spacing-4",
 					"border-radius": var(--border-radius),
 					"components": (
 						"stack": (
 							"gap": "$global.spacing-4",
-							"padding-bottom": "$global.spacing-5"
+							"padding-block-end": "$global.spacing-5"
 						),
 						"paragraph": (
 							"color": "$global.white"
diff --git a/blocks/ads-block/index.story.jsx b/blocks/ads-block/index.story.jsx
index 263ce80505..a7de05b9e6 100644
--- a/blocks/ads-block/index.story.jsx
+++ b/blocks/ads-block/index.story.jsx
@@ -36,3 +36,15 @@ export const adViewWithTopLabel = () => <ArcAdDisplay {...DEFAULT_PROPS} />;
 export const adViewHidingTopLabel = () => (
 	<ArcAdDisplay {...DEFAULT_PROPS} displayAdLabel={false} />
 );
+
+export const adminViewRightToLeft = () => (
+	<div dir="rtl">
+		<ArcAdDisplay {...DEFAULT_PROPS} isAdmin />
+	</div>
+);
+
+export const adViewWithTopLabelRightToLeft = () => (
+	<div dir="rtl">
+		<ArcAdDisplay {...DEFAULT_PROPS} />
+	</div>
+);
diff --git a/blocks/ads-block/themes/commerce.json b/blocks/ads-block/themes/commerce.json
index 57e263829e..67d830dea5 100644
--- a/blocks/ads-block/themes/commerce.json
+++ b/blocks/ads-block/themes/commerce.json
@@ -19,12 +19,15 @@
 		"styles": {
 			"default": {
 				"background-color": "$global.neutral-7",
-				"padding": "$global.spacing-4",
+				"padding-block-start": "$global.spacing-4",
+				"padding-inline-end": "$global.spacing-4",
+				"padding-block-end": "$global.spacing-4",
+				"padding-inline-start": "$global.spacing-4",
 				"border-radius": "var(--border-radius)",
 				"components": {
 					"stack": {
 						"gap": "$global.spacing-4",
-						"padding-bottom": "$global.spacing-5"
+						"padding-block-end": "$global.spacing-5"
 					},
 					"paragraph": {
 						"color": "$global.white"
diff --git a/blocks/ads-block/themes/news.json b/blocks/ads-block/themes/news.json
index 57e263829e..67d830dea5 100644
--- a/blocks/ads-block/themes/news.json
+++ b/blocks/ads-block/themes/news.json
@@ -19,12 +19,15 @@
 		"styles": {
 			"default": {
 				"background-color": "$global.neutral-7",
-				"padding": "$global.spacing-4",
+				"padding-block-start": "$global.spacing-4",
+				"padding-inline-end": "$global.spacing-4",
+				"padding-block-end": "$global.spacing-4",
+				"padding-inline-start": "$global.spacing-4",
 				"border-radius": "var(--border-radius)",
 				"components": {
 					"stack": {
 						"gap": "$global.spacing-4",
-						"padding-bottom": "$global.spacing-5"
+						"padding-block-end": "$global.spacing-5"
 					},
 					"paragraph": {
 						"color": "$global.white"

From 187e0f311b99694b2e91ed4f6b023a646c6cb482 Mon Sep 17 00:00:00 2001
From: blakeganderson <85515364+blakeganderson@users.noreply.github.com>
Date: Tue, 12 Dec 2023 15:02:38 -0500
Subject: [PATCH 2/2] updated border-radius to use logical properties

---
 .storybook/themes/news.scss           | 5 ++++-
 blocks/ads-block/themes/commerce.json | 5 ++++-
 blocks/ads-block/themes/news.json     | 5 ++++-
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/.storybook/themes/news.scss b/.storybook/themes/news.scss
index 723a9284a0..1482ef1f0a 100644
--- a/.storybook/themes/news.scss
+++ b/.storybook/themes/news.scss
@@ -276,7 +276,10 @@
 					"padding-inline-end": "$global.spacing-4",
 					"padding-block-end": "$global.spacing-4",
 					"padding-inline-start": "$global.spacing-4",
-					"border-radius": var(--border-radius),
+					"border-start-start-radius": var(--border-radius),
+					"border-start-end-radius": var(--border-radius),
+					"border-end-start-radius": var(--border-radius),
+					"border-end-end-radius": var(--border-radius),
 					"components": (
 						"stack": (
 							"gap": "$global.spacing-4",
diff --git a/blocks/ads-block/themes/commerce.json b/blocks/ads-block/themes/commerce.json
index 67d830dea5..a020e4b8c4 100644
--- a/blocks/ads-block/themes/commerce.json
+++ b/blocks/ads-block/themes/commerce.json
@@ -23,7 +23,10 @@
 				"padding-inline-end": "$global.spacing-4",
 				"padding-block-end": "$global.spacing-4",
 				"padding-inline-start": "$global.spacing-4",
-				"border-radius": "var(--border-radius)",
+				"border-start-start-radius": "var(--border-radius)",
+				"border-start-end-radius": "var(--border-radius)",
+				"border-end-start-radius": "var(--border-radius)",
+				"border-end-end-radius": "var(--border-radius)",
 				"components": {
 					"stack": {
 						"gap": "$global.spacing-4",
diff --git a/blocks/ads-block/themes/news.json b/blocks/ads-block/themes/news.json
index 67d830dea5..a020e4b8c4 100644
--- a/blocks/ads-block/themes/news.json
+++ b/blocks/ads-block/themes/news.json
@@ -23,7 +23,10 @@
 				"padding-inline-end": "$global.spacing-4",
 				"padding-block-end": "$global.spacing-4",
 				"padding-inline-start": "$global.spacing-4",
-				"border-radius": "var(--border-radius)",
+				"border-start-start-radius": "var(--border-radius)",
+				"border-start-end-radius": "var(--border-radius)",
+				"border-end-start-radius": "var(--border-radius)",
+				"border-end-end-radius": "var(--border-radius)",
 				"components": {
 					"stack": {
 						"gap": "$global.spacing-4",