From d0138b98b36b09458be20cab34324dea61808cee Mon Sep 17 00:00:00 2001 From: Jack Howard Date: Fri, 16 Jul 2021 15:27:36 -0500 Subject: [PATCH 1/4] docs: Add deprecation notice for variables --- readme.md | 2 ++ scss/homepage.md | 2 ++ scss/typography/_index.scss | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/readme.md b/readme.md index 0e619b0..15ab8f0 100644 --- a/readme.md +++ b/readme.md @@ -30,6 +30,8 @@ Include as an dependency in a custom block: - Fusion will then inject these overrides and framework. Set the following in the feature pack's blocks.json: +NOTE: sassVariableOverrides is deprecated in favor of using site-specific js values using styled-components + `feature-pack/blocks.json` ```json { diff --git a/scss/homepage.md b/scss/homepage.md index 56486bd..cf32e24 100644 --- a/scss/homepage.md +++ b/scss/homepage.md @@ -37,6 +37,8 @@ purpose: Here is an example of what a the CSS setup in the `block.json` might look like. +NOTE: sassVariableOverrides is deprecated in favor of using site-specific js values using styled-components + ``` { "cssFramework": "@wpmedia/news-theme-css", diff --git a/scss/typography/_index.scss b/scss/typography/_index.scss index 5cf258f..f156dda 100644 --- a/scss/typography/_index.scss +++ b/scss/typography/_index.scss @@ -1,6 +1,6 @@ // Typography // -// The primary and secondary font families can be overridden per website using the [Theme Settings](https://redirector.arcpublishing.com/alc/arc-products/themes/user-docs/theme-settings/) `primary-font-family` and `secondary-font-family`, respectively. +// This is now deprecated. Instead, we recommend using site-specific values and a default font value. We use styled-components to ensure this is dynamic. The primary and secondary font families can be overridden per website using the [Theme Settings](https://redirector.arcpublishing.com/alc/arc-products/themes/user-docs/theme-settings/) `primary-font-family` and `secondary-font-family`, respectively. // // Styleguide 5.0.0 From d83c1eaf2e892be8f29265f45cbb1ec0aed3fa22 Mon Sep 17 00:00:00 2001 From: Jack Howard Date: Fri, 16 Jul 2021 15:29:02 -0500 Subject: [PATCH 2/4] docs: Add deprecation notice in output --- styleguide/index.html | 1 + styleguide/item-5.html | 2 +- styleguide/section-5.html | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/styleguide/index.html b/styleguide/index.html index 07bbd74..1bf1c05 100644 --- a/styleguide/index.html +++ b/styleguide/index.html @@ -296,6 +296,7 @@

Getting Started:

Example

Here is an example of what a the CSS setup in the block.json might look like.

+

NOTE: sassVariableOverrides is deprecated in favor of using site-specific js values using styled-components

{
   "cssFramework": "@wpmedia/news-theme-css",
   "cssImport": "~@wpmedia/news-theme-css/scss/index",
diff --git a/styleguide/item-5.html b/styleguide/item-5.html
index 046a1d0..deaed18 100644
--- a/styleguide/item-5.html
+++ b/styleguide/item-5.html
@@ -272,7 +272,7 @@ 

 
             

-              
The primary and secondary font families can be overridden per website using the Theme Settings primary-font-family and secondary-font-family, respectively.

+              
This is now deprecated. Instead, we recommend using site-specific values and a default font value. We use styled-components to ensure this is dynamic. The primary and secondary font families can be overridden per website using the Theme Settings primary-font-family and secondary-font-family, respectively.

 

 
           
diff --git a/styleguide/section-5.html b/styleguide/section-5.html
index b64fa70..0e46ecf 100644
--- a/styleguide/section-5.html
+++ b/styleguide/section-5.html
@@ -272,7 +272,7 @@ 

 
             

-              
The primary and secondary font families can be overridden per website using the Theme Settings primary-font-family and secondary-font-family, respectively.

+              
This is now deprecated. Instead, we recommend using site-specific values and a default font value. We use styled-components to ensure this is dynamic. The primary and secondary font families can be overridden per website using the Theme Settings primary-font-family and secondary-font-family, respectively.

 

 
           

From d7e6e2630b75b0725b76b36a0f6b7b7e2ec35e5b Mon Sep 17 00:00:00 2001
From: Jack Howard 
Date: Fri, 16 Jul 2021 15:30:52 -0500
Subject: [PATCH 3/4] docs: Add deprecation notice for base color themes

---
 scss/_colors.scss | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scss/_colors.scss b/scss/_colors.scss
index c99bd71..4468afd 100644
--- a/scss/_colors.scss
+++ b/scss/_colors.scss
@@ -7,6 +7,8 @@
 
 // Base Colors for the theme.
 //
+// NOTE: This is being deprecated. We are in the process of improving enhanced styles and using styled-components to achieve this composition.
+//
 // $primary-color - #1B6FA6; Primary color
 // $secondary-color - #1B6FA6; Placeholder for the future
 // $success-color - #00A321; Success color

From ed59f19ba753bf4f58f4dd0fe2110a4fc3db76a1 Mon Sep 17 00:00:00 2001
From: Jack Howard 
Date: Fri, 16 Jul 2021 15:31:09 -0500
Subject: [PATCH 4/4] docs: Update docs output

---
 styleguide/item-3-1.html  | 4 ++++
 styleguide/section-3.html | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/styleguide/item-3-1.html b/styleguide/item-3-1.html
index 407cfe4..4a7cb67 100644
--- a/styleguide/item-3-1.html
+++ b/styleguide/item-3-1.html
@@ -256,6 +256,10 @@ 

               

             
 
+            

+              
NOTE: This is being deprecated. We are in the process of improving enhanced styles and using styled-components to achieve this composition.

+

 
             
    
               
  • 
diff --git a/styleguide/section-3.html b/styleguide/section-3.html
index f6676db..1eecfbc 100644
--- a/styleguide/section-3.html
+++ b/styleguide/section-3.html
@@ -286,6 +286,10 @@ 
    
               
    
             
 
+            
    
+              
    NOTE: This is being deprecated. We are in the process of improving enhanced styles and using styled-components to achieve this composition.
    
+
    
 
             
      
               
    •