Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fabrice-Fabio
Copy link

@Fabrice-Fabio Fabrice-Fabio commented Nov 25, 2023

Description [Update readme]

  • summary of the changes and the related issue
  • relevant motivation and context

@quetool

- Setting up verify Api
- Setting up deeplink with wallet connect
@@ -267,6 +277,11 @@ await wcClient.disconnectSession(
);
```

### Setting up Deeplinks

If you want to set up deeplinks on wallet connect, you must configure your device so that the scheme of your deeplink is compatible with "wc://"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean here. In order to register a deepLink so your wallet can be opened from a dapp (or your dapp called back from the wallet fwiw) you should add your custom scheme (for instance myawesomewallet://) in the iOS Info.plist file under the CFBundleURLTypes key and an intent filter in the Android's Manifest.xml file, then pass this custom scheme in the PairingMetadata object in the redirect parameter.
This is also something we should add in the docs page btw.

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants