Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Contributors section to README #239

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

robin-thomas
Copy link
Contributor

Solves #159

@robin-thomas robin-thomas marked this pull request as ready for review August 23, 2023 23:40
@robin-thomas
Copy link
Contributor Author

@PaulRBerg Let me know if you want me to remove the Credits section and/or rearrange the Contributors section.

@PaulRBerg
Copy link
Collaborator

Thanks for your PR, @robin-thomas.

Yes, let's please replace the Credits section with your newly-added Contributors.

@robin-thomas
Copy link
Contributor Author

@PaulRBerg Getting the error Please set GH_OAUTH_TOKEN as an environment variable in the workflow.

@PaulRBerg
Copy link
Collaborator

@robin-thomas, yeah that's expected because the CI workflows run some integration tests using the GitHub API.

Typically I would ask contributors to add a GH_OAUTH_TOKEN secret in their fork, but your PR only changes the README, so there's no need to run the CI.

@PaulRBerg PaulRBerg merged commit ad412ee into WalletConnect:develop Aug 24, 2023
@robin-thomas robin-thomas deleted the docs_contributors branch August 24, 2023 08:44
@robin-thomas
Copy link
Contributor Author

@PaulRBerg What github permission does the GH_OAUTH_TOKEN token require?

GAEAlimited pushed a commit to GAEAlimited/create-gsc-app that referenced this pull request Dec 5, 2023
* docs: add Contributors section to README

* docs: replace credits section with contributors section

* docs: flip order of sections

---------

Co-authored-by: Paul Razvan Berg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants