Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add doc on how to contribute to this repo #241

Merged
merged 6 commits into from
Aug 28, 2023

Conversation

robin-thomas
Copy link
Contributor

No description provided.

@robin-thomas robin-thomas marked this pull request as ready for review August 24, 2023 12:32
@robin-thomas
Copy link
Contributor Author

@PaulRBerg Do you know how to pass the secret GH_OAUTH_TOKEN from my forked repo to CI workflow in https://github.com/PaulRBerg/create-eth-app/blob/develop/.github/workflows/integration.yaml.

To my knowledge, that's not possible. Hence, wanted to check how do you get contributors to do this.

@PaulRBerg
Copy link
Collaborator

Yeah I did a little bit of research and that doesn't seem to be possible.

wanted to check how do you get contributors to do this

I thought that adding GH_OAUTH_TOKEN to your fork would make it work. But it looks like it doesn't because the CI check is still run in the context of my repository.

more research is needed to find a solution.

@robin-thomas
Copy link
Contributor Author

@robin-thomas
Copy link
Contributor Author

robin-thomas commented Aug 25, 2023

@PaulRBerg You can have the secret added to this repo, and since you are using pull_request and not pull_request_target event type, forked repos wont be able to access the secrets from this repo (since the CI is run in this repo anyway).

@PaulRBerg PaulRBerg added the documentation Improvements or additions to documentation label Aug 28, 2023
@PaulRBerg
Copy link
Collaborator

Thanks for your help, @robin-thomas.

I ended up removing the pull_request target event because it appears to cause a lot of trouble. Many PRs, such as yours, do not require a re-run of the integration tests because they don't touch production code.

When the production code is updated, I can manually run the integration tests in the context of the PR head branch.

@PaulRBerg PaulRBerg merged commit 5081751 into WalletConnect:develop Aug 28, 2023
@robin-thomas robin-thomas deleted the docs_contributing branch August 28, 2023 14:02
GAEAlimited pushed a commit to GAEAlimited/create-gsc-app that referenced this pull request Dec 5, 2023
* docs: add doc on how to contribute to this repo

* docs: run prettier

* docs: update permissions for PAT

* docs: update permissions for PAT

* docs: remove portion about secrets

* docs: update formatting

---------

Co-authored-by: Paul Razvan Berg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants