Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Chain filtering not applied to wallets list #20

Open
DamirSQA opened this issue Jul 11, 2023 · 6 comments
Open

[bug] Chain filtering not applied to wallets list #20

DamirSQA opened this issue Jul 11, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@DamirSQA
Copy link

DamirSQA commented Jul 11, 2023

Link to minimal reproducible example

/

Summary

Greetings, @web3modal/standalone package is replaced In favour of @walletconnect/modal, and it seems that standaloneChains[chainId] property is changed to chains: [chainId].
Aside from the issue, is there a way to add only specific wallet(s)?

image

List of related npm package versions

2.5.9

@DamirSQA DamirSQA added the bug Something isn't working label Jul 11, 2023
@xzilja
Copy link
Contributor

xzilja commented Jul 12, 2023

@DamirSQA you can add specific wallets via options https://docs.walletconnect.com/2.0/web/walletConnectModal/modal/options

@xzilja xzilja changed the title [bug] [bug] Chain filtering not applied to wallets list Jul 12, 2023
@DamirSQA
Copy link
Author

Hi @0xasimetriq had a look, but it doesn't seem that it solves it for me. Regarding mentioned chanId issue, it worked fine in 2.4.7 and versions before.

@xzilja
Copy link
Contributor

xzilja commented Jul 12, 2023

Filtering by chain id might be an actual bug, I need to look into this, but for your other question

Aside from the issue, is there a way to add only specific wallet(s)?

You can use options for explorer to filter out / only specify wallets you want. What issue are you facing there?

@DamirSQA
Copy link
Author

Thanks, I've used enableExplorer: false for now, as there's only one mobile wallet to be displayed in this moment. However, I've noticed that If I add desktopWallets :[...], that wallet is present in modal as on the image, but that's not the case for mobileWallets: [...]. Though, I've checked it out in browser, not the actual device, but just to point it out, if it's something you'd like to have a look into as well.
image

@xzilja
Copy link
Contributor

xzilja commented Jul 12, 2023

What's displayed on mobile when you add it via mobileWallets?

@mr-zwets
Copy link

mr-zwets commented Oct 4, 2023

yeah the mobileWallets setting doesn't work for me either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants